Skip to content

feat(settings): the member welcome panel shows where the message comes from - #4434

Merged
dolho merged 1 commit into
devfrom
feature/1198-template-welcome
Nov 10, 2026
Merged

dolho merged 1 commit into
devfrom
feature/1198-template-welcome

Conversation

@vybe

@vybe vybe commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Part of abilityai/trinity-enterprise#1198 (the panel half). Companion enterprise PR: abilityai/trinity-enterprise#1213. Draft until the chain is in.

What

  • src/frontend/src/components/settings/MemberWelcomePanel.vue: shows where the member welcome comes from — the message saved here, the agent template's welcome: block, or the default — with the template's status (ok / unreadable / invalid) and its message, and the preview follows that precedence.
  • src/frontend/src/stores/memberWelcome.js: carries the template fields from the settings read.
  • src/frontend/tests/unit/memberWelcomePanel.spec.js: source, status and precedence cases.
  • No backend, schema or agent-server change in this repo; no .claude or gitlink change.

Review + security

/review (report-only) over both halves: no finding on this half; copy checked for internal product terms (none). /cso --diff: nothing.

Tests

Panel spec + neighbours green at implement (46 frontend). Full vitest not run here — CI's.

Before merge

🤖 Generated with Claude Code

…from (ent#1198)

The Settings welcome panel now reads the message's source: the agent
template, a text set here, the shipped default, or off. It shows the agent
template's own message as a member sees it, says why a refused or unreadable
one is not used, lists the keys it ignored, and when a text set here
overrides it, offers "Use the template's welcome". When the template supplies
the message, the template also sets the greeting switch.

New markup uses semantic and gray tokens only; the raw-colour and
loading-gate ratchets are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vybe vybe added the ui PR touches the frontend UI — triggers Playwright e2e tests label Nov 10, 2026
@vybe
vybe marked this pull request as ready for review November 10, 2026 02:20
@vybe

vybe commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Validation: APPROVE at 4a452c3a5. No blockers.

  • CI: every check passes, including regression diff (run 42739311158, completed 02:19Z). The cancelled frontend-e2e and journey-impact rows are double-fires, each superseded by a passing twin.
  • Tests: memberWelcomePanel.spec.js plus the loading-gate, raw-color and source-text ratchet specs passed (4 files, 46 tests).
  • Against an enterprise without the new settings fields (gitlink 0643b6803): the panel works out the source from text / is_default / replaces_hello as before, hides the template blocks and keeps the Restore button. A throwaway spec with that response shape passed 3/3.
  • Merge order: abilityai/trinity-enterprise#1213 → enterprise gitlink bump on dev → this PR.

Warnings:

  • W1: there's no closing keyword. This is a cross-tracker reference, so the issue status is updated by hand.
  • W2: no spec covers a response without source. The fallback was checked with a throwaway spec only. This is recorded as a follow-up and doesn't block the merge.

@dolho dolho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with /validate-pr at 4a452c3a5 (Lane B, frontend only), together with abilityai/trinity-enterprise#1213. Approving.

Verified

  • memberWelcomePanel.spec.js mounts the panel; with the raw-colour, loading-gate and source-text ratchets: 46 passed.
  • The panel degrades on an older server: with no source in the response it derives one from is_default / text, so merging this before the enterprise half shows today's panel, not a broken one.
  • save(null) reads source after the store refresh, so "The agent template's welcome is back." and "Default restored." each appear for the right outcome.
  • Template text and the server's message / code are rendered as text ({{ }}), never as HTML.
  • No raw palette colours beyond the grays already used in this file; status colours use the semantic tokens.
  • CI: Tier 1 green. The three CANCELLED entries (journey-impact, changes, report) were each superseded by a later successful run.

Non-blocking

  1. The body says "Draft until the chain is in", but the PR is open for review. If it should wait for #1213 and the gitlink bump, marking it draft would stop it being picked up by a merge train.
  2. The switch is locked while the template is the source and the text is untouched; editing the message unlocks it. That is explained under the switch, but there is no way to keep the template's text and change only the switch. Fine if intended (T3: the flag follows the text's source).
  3. No closing keyword ("Part of …#1198"); #1213 carries Fixes.

@dolho
dolho merged commit e6d36a9 into dev Nov 10, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui PR touches the frontend UI — triggers Playwright e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants