Repository navigation
feat(settings): the member welcome panel shows where the message comes from - #4434
Merged
Merged
Conversation
…from (ent#1198) The Settings welcome panel now reads the message's source: the agent template, a text set here, the shipped default, or off. It shows the agent template's own message as a member sees it, says why a refused or unreadable one is not used, lists the keys it ignored, and when a text set here overrides it, offers "Use the template's welcome". When the template supplies the message, the template also sets the greeting switch. New markup uses semantic and gray tokens only; the raw-colour and loading-gate ratchets are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vybe
marked this pull request as ready for review
November 10, 2026 02:20
Contributor
Author
|
Validation: APPROVE at
Warnings:
|
dolho
approved these changes
Nov 10, 2026
dolho
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with /validate-pr at 4a452c3a5 (Lane B, frontend only), together with abilityai/trinity-enterprise#1213. Approving.
Verified
memberWelcomePanel.spec.jsmounts the panel; with the raw-colour, loading-gate and source-text ratchets: 46 passed.- The panel degrades on an older server: with no
sourcein the response it derives one fromis_default/text, so merging this before the enterprise half shows today's panel, not a broken one. save(null)readssourceafter the store refresh, so "The agent template's welcome is back." and "Default restored." each appear for the right outcome.- Template text and the server's
message/codeare rendered as text ({{ }}), never as HTML. - No raw palette colours beyond the grays already used in this file; status colours use the semantic tokens.
- CI: Tier 1 green. The three
CANCELLEDentries (journey-impact,changes,report) were each superseded by a later successful run.
Non-blocking
- The body says "Draft until the chain is in", but the PR is open for review. If it should wait for #1213 and the gitlink bump, marking it draft would stop it being picked up by a merge train.
- The switch is locked while the template is the source and the text is untouched; editing the message unlocks it. That is explained under the switch, but there is no way to keep the template's text and change only the switch. Fine if intended (T3: the flag follows the text's source).
- No closing keyword ("Part of …#1198"); #1213 carries
Fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of abilityai/trinity-enterprise#1198 (the panel half). Companion enterprise PR: abilityai/trinity-enterprise#1213. Draft until the chain is in.
What
src/frontend/src/components/settings/MemberWelcomePanel.vue: shows where the member welcome comes from — the message saved here, the agent template'swelcome:block, or the default — with the template's status (ok / unreadable / invalid) and its message, and the preview follows that precedence.src/frontend/src/stores/memberWelcome.js: carries the template fields from the settings read.src/frontend/tests/unit/memberWelcomePanel.spec.js: source, status and precedence cases..claudeor gitlink change.Review + security
/review(report-only) over both halves: no finding on this half; copy checked for internal product terms (none)./cso --diff: nothing.Tests
Panel spec + neighbours green at implement (46 frontend). Full vitest not run here — CI's.
Before merge
src/backend/enterprisegitlink bump that carries it.dev(094815a5f); merge-tree clean against dev, feat(agents): an agent's own default model, one resolver for every turn path (ent#1202) #4431 and feat(workspace): member sees 'starting' and held sends while their agent restarts (ent#1201, B) #4429.🤖 Generated with Claude Code