Skip to content

feat(ui): rename the agent Sharing tab to Channels (abilityai/trinity-enterprise#225) - #4307

Merged
vybe merged 2 commits into
devfrom
feature/ent225-channels-tab
Nov 6, 2026
Merged

vybe merged 2 commits into
devfrom
feature/ent225-channels-tab

Conversation

@dolho

@dolho dolho commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The agent's Sharing tab is now Channels, with id channels. This is the rename the operator ruled on 2026-08-21, with no extra top-level tabs.
  • sharing is an alias, so old ?tab=sharing links open the tab.
  • The panel's heading now says Channels instead of "Share this agent", and its line about teammates links to Settings › People instead of the Access tab, which moved there earlier.
  • UI copy, user docs, requirements and feature flows now say Channels tab. "Sharing" as the act of sharing an agent stays, as do SharingPanel.vue, doc filenames, and whats-new and announcement history.

Behaviour to review

Test Plan

  • Specs updated, with new cases for the label and for an old ?tab=sharing link.
  • Mutations, all red: alias removed, old label, old id.
  • test_3563_slack_oauth_redirect_base and test_client_roster pass.

Local full frontend run: 4 failures out of 7297, in mobileAdminQueueWalk3302 and portalInboxRooms. They pass alone, and this diff doesn't touch that code.

Not run: a browser or live stack on this branch. No security audit, as this is a rename.

Fixes abilityai/trinity-enterprise#225

🤖 Generated with Claude Code

…-enterprise#225)

People looking for Slack or Telegram setup didn't expect it under Sharing. By
operator ruling this is a rename only. The id becomes `channels`, and `sharing`
stays an alias so old `?tab=sharing` links keep working. Settings › Channels
stays as it is, so its row now says it opens the Channels tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dolho dolho added the ui PR touches the frontend UI — triggers Playwright e2e tests label Nov 6, 2026
Abilityai/trinity-enterprise#225)

The panel still opened with "Share this agent" and sent teammates to an Access
tab that moved to Settings › People. It's now headed Channels, and the line links
to where those people are managed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@vybe vybe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge-train: batch validated on train/20261106-1802 (train PR #4320, all gating checks green). Validated at 21cbe94, lane B: 0 critical, every changed value executed by a mounted spec with red mutations.

@vybe
vybe merged commit a86451a into dev Nov 6, 2026
28 of 29 checks passed
dolho added a commit that referenced this pull request Nov 11, 2026
…er controls; #4310 review

dev was 111 commits ahead. 47 files conflicted; 12 of them code.

The merge
- #4307 renamed the agent's Sharing tab to Channels. This branch moves the
  console into Settings › Channels, so there is no such tab: `sharing` and
  `channels` both alias to `settings`. Docs and copy keep this branch's
  wording wherever dev only renamed the tab (110 of 114 doc hunks).
- #4177 added block / revoke / approve / unblock to the client roster in
  SharingPanel.vue, which this branch deletes. Those controls are ported
  into agent-settings/channels/ClientRoster.vue (review blocking 1): the
  Access column, the per-row actions and the confirm dialog. The spec moves
  with them (clientRosterControls.mount.spec.js).
- The roster and the pending requests are separate components here, so a
  decision in one re-reads the other through the pane.

Review items
- Medium 3: the header no longer says "Not reachable anywhere yet" while a
  check failed or is still running. Each row announces that its check
  started; reachability is said once every surface answered, and a failed
  check is named ("Couldn't check Slack").
- Low 4: WhoCanChat, SpeaksOutside and ClientRoster use the `api` client.
- Low 5: a different agent clears the previous agent's policy, requests,
  roster, model and instructions at once, and a late answer for the agent
  left behind is dropped.
- Info 6: client_roster_service's docstring no longer calls #21 a follow-up.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui PR touches the frontend UI — triggers Playwright e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants