Skip to content

feat(ui): move the Channels console into Settings › Channels (abilityai/trinity-enterprise#340) - #4310

Draft
dolho wants to merge 3 commits into
devfrom
feature/ent340-channels-settings
Draft

dolho wants to merge 3 commits into
devfrom
feature/ent340-channels-settings

Conversation

@dolho

@dolho dolho commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Still a draft: needs a look in a browser before it is marked ready. dev is merged in (#4307 and #4177 included). #4177's block, revoke, approve and unblock controls are ported into channels/ClientRoster.vue, and sharing / channels both alias to Settings › Channels. The ported roster dialog and the 390px layout have only been exercised in mounted tests since the merge, not in a running app.

Summary

  • The agent's Sharing tab is gone. Everything moves into Settings › Channels, following the operator's re-scope of 2026-10-13 on abilityai/trinity-enterprise#340: a header line, then Who can chat, Messaging, Web, How it speaks outside and Who has talked to it.
  • Config, pending requests and the roster open in dialogs, and the dedicated Slack bot is a tab in the Slack dialog where it's entitled.
  • The MCP connector moves to Settings › Integrations. File sharing was already in Storage.
  • ?tab=sharing and ?tab=channels land on the pane, and &channel=slack|telegram|whatsapp|voip opens that dialog.

Behaviour to review

  • Failed loads: a 5xx or no response now reads "Couldn't check" or "Couldn't load" with Retry, not "Not connected", "No one yet" or "Not set". A 4xx still reads as not connected. An editor can't open over a failed value, since saving would overwrite what's stored.
  • Editing is now a save step: the public chat model used to save on change. It now has Save and Cancel in a dialog, as the mock shows.
  • &channel= is new: the ruling says it "still opens", but nothing read it before.
  • Not built from the mock: the "2 live" count on the Settings rail, which would load every channel's status just to open Settings.
  • Agent prompt: one line told agents to send operators to the Sharing tab for file sharing. It now names Settings › Storage.
  • Slack OAuth return: the backend still redirects to ?tab=sharing, which works through the alias. test: pin the Slack OAuth redirect origin, the agent dashboard refusal text, and the SSH port probe's bind-only behaviour (abilityai/trinity-enterprise#1117) #4298 pins that URL.
  • Screenshot: sharing-and-access/access-control.md embeds an image of the old tab and needs retaking.

Test Plan

  • channelsPane.mount.spec.js, through the real pane and sections, with the channel panels stubbed and the network mocked.
  • Ported or extended: pending requests, channel row, deep links and tab aliases.
  • 24 mutations, all red. One stayed green at first and got a test.
  • Browser check against mocked API responses in light, dark and 390px: matches the operator's mock, no sideways scroll, and deep links open their dialog.
  • Production build passes. The colour baseline is edited by hand for the affected files only, keeping its history.

Local full frontend run: 5 failures out of 7495, in mobileAdminQueueWalk3302 and portalInboxRooms. Both files pass alone, and this diff doesn't touch that code. I didn't test them on plain dev.

Not run: a live stack. No /cso --diff: frontend only, calling the same gated routes.

Fixes abilityai/trinity-enterprise#340

🤖 Generated with Claude Code

…ai/trinity-enterprise#340)

The agent's Sharing tab mixed who gets in, where the agent is reachable and how it
speaks outside in one long scroll. By the operator's re-scope of 2026-10-13 under
trinity#966, that all becomes sections of the Settings › Channels pane, with config
in dialogs. The MCP connector moves to Settings › Integrations. `?tab=sharing` and
`?tab=channels` land on the pane, and `&channel=` opens a channel's dialog.

A value that failed to load now says so instead of reading as "Not connected", no
one or "Not set", and an editor can't open over it, since saving would overwrite
what's stored. The agent prompt's pointer for turning on file sharing now names
Settings › Storage, where it has been since ent#888.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dolho dolho added the ui PR touches the frontend UI — triggers Playwright e2e tests label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

⚠️ Nightly unit-suite check skipped — merge conflict against dev.

Resolve by running git merge dev locally and pushing the result. The next nightly run will re-test once the conflict is gone.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

⚠️ Live-instance suite skipped — merge conflict against dev.

Resolve by merging dev locally and pushing the result; the next nightly re-tests.

…Channels

SharingPanel.vue was removed by this PR; the manifest still listed it as a
source, which the screenshot guard (and test_2089_screenshot_guard) treat as
a blocking integrity error. The sharing UI now lives in
agent-settings/channels/WhoCanChat.vue, reached at ?tab=settings&section=channels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@obasilakis obasilakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against dev and the 2026-10-13 re-scope comment on trinity-enterprise#340.

Blocking

  1. The client roster loses block / revoke / approve / unblock. #4177 merged to dev on 2026-11-06 and added the Access column, approveClient, askClientControl, runClientControl and their confirm dialogs to SharingPanel.vue. This PR deletes SharingPanel.vue, and agent-settings/channels/ClientRoster.vue (table at lines 17–45) has no Access column and no actions. A conflict resolved by keeping the delete removes shipped controls from the UI while their backend routes stay live. The #340 re-scope says these controls land in the roster. Port the column, actions and dialogs into ClientRoster.vue, with a mount test. (The PR body already names this as the draft blocker.)
  2. Conflicts with dev in 47 files. dev is 44 commits ahead (#4307, #4177, #4306, #4336). The code files are SharingPanel.vue, ChannelsPane.vue, AccessPanel.vue, utils/agentTabs.js, views/AgentDetail.vue, views/Settings.vue, four agent-detail / channels specs, routers/sharing.py and services/client_roster_service.py. The rest are docs (feature flows, requirements, user docs). CI has no run while the PR conflicts.

Medium
3. The header says "Not reachable anywhere yet" when a check failed. In ChannelsPane.vue, the reachable computed (around line 45) drops null (failed) surfaces. When the remaining surfaces are all unconnected, paneSummary (utils/channelsPane.js:57) turns the empty list into "Not reachable anywhere yet". Repro: Slack status returns 500 and there are no public links. The header reads Restricted · No one waiting · Not reachable anywhere yet while Slack's state is unknown. The same text also shows while rows are still loading, as soon as the first row reports "not connected". This breaks the #340 rule that a failed load never reads as "not connected", and this PR's own §46.0 "Honest states". Say nothing about reachability while any surface is null or pending, or say "Couldn't check Slack". Add a test for this case.

Low
4. WhoCanChat.vue, SpeaksOutside.vue and ClientRoster.vue call raw axios with authStore.authHeader. Invariants #6 and #7 route API calls through the api client or a store. The pattern was copied from SharingPanel.vue, but these are new files, and ChannelConfigRow in this PR already uses api.
5. The watch(agentName) handlers in WhoCanChat.vue and ClientRoster.vue don't reset policyLoaded, policy or clients before reloading. If the view is reused across agents, the previous agent's policy and roster stay visible and clickable until the fetch returns, and setAccessMode's early return compares against the old agent's policy.

Info
6. services/client_roster_service.py:5 still calls #21 "a separate follow-up"; #21 has shipped.
7. The Restricted/Open control in WhoCanChat.vue is hand-rolled with raw gray classes, carried over from SharingPanel. There is no segmented-control primitive yet, so the ratchet allows it.

AC coverage (#340 re-scope)

  • Done: one entry point per channel, dedicated Slack bot tab, who-can-chat, roster summary, Web section, MCP connector moved to Integrations, how-it-speaks-outside, file sharing moved to Storage, deep links.
  • Partial: header (item 3), honest load states (rows are correct, the header is not), primitives (item 7).
  • Not done: #21 controls in the roster (item 1).
  • Changed: the Connection / Behavior / Identity sections reuse the existing channel panels.
  • Not checked here: narrow-width layout. You report a browser check at 390px.

Tests (PR head, fresh npm ci)

  • Full vitest run: 7493 of 7495 pass. The 2 failures (activityWave.mount.spec.js, portalAgentsAtCentre.spec.js) also fail at the merge base.
  • Raw-color, loading-gate and source-text ratchets plus the two new specs: 66 of 66 pass.
  • The hand-edited raw-color-baseline.json passes, including the check for counts above the real numbers.

…er controls; #4310 review

dev was 111 commits ahead. 47 files conflicted; 12 of them code.

The merge
- #4307 renamed the agent's Sharing tab to Channels. This branch moves the
  console into Settings › Channels, so there is no such tab: `sharing` and
  `channels` both alias to `settings`. Docs and copy keep this branch's
  wording wherever dev only renamed the tab (110 of 114 doc hunks).
- #4177 added block / revoke / approve / unblock to the client roster in
  SharingPanel.vue, which this branch deletes. Those controls are ported
  into agent-settings/channels/ClientRoster.vue (review blocking 1): the
  Access column, the per-row actions and the confirm dialog. The spec moves
  with them (clientRosterControls.mount.spec.js).
- The roster and the pending requests are separate components here, so a
  decision in one re-reads the other through the pane.

Review items
- Medium 3: the header no longer says "Not reachable anywhere yet" while a
  check failed or is still running. Each row announces that its check
  started; reachability is said once every surface answered, and a failed
  check is named ("Couldn't check Slack").
- Low 4: WhoCanChat, SpeaksOutside and ClientRoster use the `api` client.
- Low 5: a different agent clears the previous agent's policy, requests,
  roster, model and instructions at once, and a late answer for the agent
  left behind is dropped.
- Info 6: client_roster_service's docstring no longer calls #21 a follow-up.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@dolho

dolho commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Review response, at 64c0afa8b

Thanks, obasilakis. dev is merged in and every item is addressed. The PR stays a draft until the ported roster has been looked at in a browser.

# Item Status
Blocking 1 The roster loses block / revoke / approve / unblock Fixed. Ported from #4177's SharingPanel.vue into agent-settings/channels/ClientRoster.vue: the Access column, the per-row actions and the confirm dialogs. The spec moved with them (clientRosterControls.mount.spec.js).
Blocking 2 Conflicts with dev in 47 files Fixed. dev was 111 commits ahead. Of 114 doc hunks, 110 were #4307's tab rename only and keep this branch's "Settings › Channels" wording. sharing and channels both alias to settings; there is no Channels tab.
Medium 3 Header says "Not reachable anywhere yet" when a check failed Fixed. Each row now announces when its check starts. The header says nothing about reachability until every surface has answered, and names a failed check ("Couldn't check Slack"). Three new tests cover your repro, the pending case and the mixed case; reverting the rule turns two red.
Low 4 Raw axios in the three new components Fixed. WhoCanChat, SpeaksOutside and ClientRoster use the api client.
Low 5 State not reset when the agent changes Fixed. A different agent clears the previous policy, requests, roster, model and instructions at once. A late answer for the previous agent is dropped in WhoCanChat and ClientRoster.
Info 6 client_roster_service.py calls #21 a follow-up Fixed in the merge.
Info 7 Hand-rolled Restricted/Open control Not changed; there is still no segmented-control primitive.

One thing the port needed that #4177 did not: the roster and the pending requests are separate components here. An approval in the roster now re-reads the pending list in Who can chat, and a decision there re-reads the roster, both through ChannelsPane.vue.

Tests

  • The six specs for this area: 86 passed.
  • Raw-colour, loading-gate and source-text ratchets: 28 passed, with the merged baseline untouched.
  • Full vitest run: 7935 of 7941. Five of the six failures (mobileAdminQueueWalk3302, portalInboxRooms) pass when run alone. The sixth (ent1117VendoredDompurify) fails locally because this worktree has DOMPurify 3.4.13 installed and dev now pins ^3.4.17.
  • Backend: test_ent21_channel_client_controls, test_client_roster, test_message_router_access_gate and two guards: 85 passed. One Alembic head.

Not done

  • No browser check since the merge. The ported dialog and the 390px layout are covered by mounted tests only.
  • Older feature-flow docs still name SharingPanel.vue (public-agent-links.md, agent-sharing.md, slack-channel-routing.md). They were stale on this branch before the merge; channel-client-controls.md is updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui PR touches the frontend UI — triggers Playwright e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants