Skip to content

macOS app: build number from VERSION so Sparkle can offer updates #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AVADSA25 merged 2 commits into from
Oct 8, 2026
Merged

macOS app: build number from VERSION so Sparkle can offer updates #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16cd88a
macOS app: build number from VERSION so Sparkle can offer updates
Mikarina13 Oct 8, 2026
0694e1a
test: run the bundle build part only on macOS (CI is Linux)
Mikarina13 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packaging/macos/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>3.2.0</string>
<string>3.6.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<string>3.6.0</string>
<key>LSMinimumSystemVersion</key>
<string>13.0</string>
<key>NSHumanReadableCopyright</key>
Expand Down
5 changes: 5 additions & 0 deletions packaging/macos/build_app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ APP_VERSION="$(tr -d '[:space:]' < "$REPO/VERSION" 2>/dev/null || true)"
if [ -n "$APP_VERSION" ] && command -v plutil >/dev/null 2>&1; then
plutil -replace CFBundleShortVersionString -string "$APP_VERSION" "$CONTENTS/Info.plist"
echo "==> bundle CFBundleShortVersionString = $APP_VERSION (from VERSION)"
# Sparkle decides "is this newer?" from CFBundleVersion (the appcast's sparkle:version),
# not the short string. It stayed "1" on every build, so no installed copy was ever
# offered an update. Use the same version.
plutil -replace CFBundleVersion -string "$APP_VERSION" "$CONTENTS/Info.plist"
echo "==> bundle CFBundleVersion = $APP_VERSION (from VERSION)"
fi
printf 'APPL????' > "$CONTENTS/PkgInfo"

Expand Down
17 changes: 17 additions & 0 deletions tests/test_app_bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,20 @@ def test_build_assembles_bundle_and_selftest_passes():
capture_output=True, text=True, timeout=60,
)
assert st.returncode == 0, f"--selftest failed: {st.stderr}\n{st.stdout}"


def test_the_bundle_carries_the_release_version_as_its_build_number():
# Sparkle offers an update only when the appcast's sparkle:version (CFBundleVersion) is
# higher than the installed one. It stayed "1" on every build, so no installed copy was
# ever offered an update. Both version keys now come from VERSION.
import plistlib
version = (REPO / "VERSION").read_text(encoding="utf-8").strip()
static = plistlib.loads((PKG / "Info.plist").read_bytes())
assert static["CFBundleVersion"] == static["CFBundleShortVersionString"] == version, "static plist matches VERSION"
if sys.platform != "darwin":
return # the build itself needs macOS (Swift/AppKit launcher, plutil)
with tempfile.TemporaryDirectory() as td:
r = subprocess.run(["bash", str(BUILD), "--out", td, "--clean"], capture_output=True, text=True, timeout=120)
assert r.returncode == 0, r.stderr
built = plistlib.loads((Path(td) / "Sovereign AI Workstation.app" / "Contents" / "Info.plist").read_bytes())
assert built["CFBundleVersion"] == built["CFBundleShortVersionString"] == version
Loading