Repository navigation
macOS app: build number from VERSION so Sparkle can offer updates - #452
Merged
Merged
Conversation
Sparkle compares CFBundleVersion (the appcast's sparkle:version), not the short version string. It stayed "1" on every build (3.1.0 through 3.6.0), so an installed copy was never offered a newer release. build_app.sh now sets CFBundleVersion from VERSION alongside CFBundleShortVersionString, and the static Info.plist matches VERSION (3.6.0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sparkle decides whether an update is newer from
CFBundleVersion(the appcast'ssparkle:version). Every build so far hadCFBundleVersion=1(the published 3.2.0 appcast too), so an installed copy would never be offered 3.6.0.build_app.shnow setsCFBundleVersionfromVERSIONalong withCFBundleShortVersionString; the staticInfo.plistmatchesVERSION(3.6.0).Needed before publishing the 3.6.0 update (Mickael, 8 Oct: "publish the update and buyer link"). The 3.6.0 app must be rebuilt, re-signed and re-notarized after this.
Checks
tests/test_app_bundle.py: new test builds the bundle and checks both version keys equalVERSION; negative control on main: fails. Bundle, packaging and release tests: 17 passed.🤖 Generated with Claude Code