Skip to content

bug: keep repeating timers running after a throw, and gone after an unload - #213

Merged
lukepolo merged 2 commits into
mainfrom
bug/repeating-timer-survives-throw
Oct 5, 2026
Merged

lukepolo merged 2 commits into
mainfrom
bug/repeating-timer-survives-throw

Conversation

@lukepolo

@lukepolo lukepolo commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
  • SwiftlyS2 drops a repeating timer for good the first time its callback throws; TimerUtility.Repeat and the practice plugin's 1s and 0.1s loops now catch and log instead
  • SwiftlyS2 also runs a repeating timer's first pass even if it was cancelled before that tick, so a killed timer now checks before it runs
  • SwiftlyS2 only tears a plugin down once Unload returns, and a hot reload loads the new build either way; the match and practice plugins' unloads can no longer throw, and the match plugin clears its timers in a finally

@lukepolo lukepolo changed the title bug: keep repeating timers running after a callback throws bug: keep repeating timers running after a throw, and gone after an unload Oct 5, 2026
@lukepolo
lukepolo merged commit a22ff3e into main Oct 5, 2026
6 checks passed
@lukepolo
lukepolo deleted the bug/repeating-timer-survives-throw branch October 5, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant