Update subject priority for sequential selection - #339
Open
yuenmichelle1 wants to merge 3 commits into
Open
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| if self.id is None: | ||
| raise ObjectNotSavedException | ||
|
|
| side_effect=[ | ||
| iter([set_member_subject_1]), | ||
| iter([set_member_subject_2]), | ||
| ], |
There was a problem hiding this comment.
closing bracket does not match indentation of opening bracket's line
continuation line with same indent as next logical line
| with patch.object(self.subject, "save") as mock_save, \ | ||
| patch( | ||
| "panoptes_client.panoptes.LinkResolver.__getattr__", | ||
| return_value=[subject_set_1, subject_set_2], |
There was a problem hiding this comment.
continuation line under-indented for hanging indent
| set_member_subject_2 = MagicMock() | ||
|
|
||
| with patch.object(self.subject, "save") as mock_save, \ | ||
| patch( |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
| with self.assertRaises(ObjectNotSavedException): | ||
| self.subject.update_priority(1) | ||
|
|
||
| def test_update_priority_updates_priority_for_saved_subject(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of this panoptes issue: zooniverse/panoptes#4582
TL;DR of the issue is that when project teams want to set up sequential subject selection BUT did not upload
prioritywithin subject metadata on initial upload, Designator does not see updatedprioritywhen project team updates subject metadata. [Eg script of how project teams update subject metadata found here: https://github.com/zooniverse/Data-digging/blob/master/scripts_Utility/edit_metadata_indiv.py] Mainly because Designator looks at a Subject's corresponding SetMemberSubject to view priority.This change allows project teams a way to not only update subject metadata's priority but also the SetMemberSubject for Designator to show correct subject order.