Repository navigation
Fix the broken system test and remove unused TryFrom - #8
Merged
Merged
Conversation
tests/run still set HALIDE_CACHE_DIR, which b55f91c replaced with --cache-dir, so it has been failing since. Replace it with integration tests that run the halide-cache binary around a small Python generator, as in real use, and check hits, misses and sharing between checkouts at different paths. Later changes add their scenarios here. As part of this change the tests are rewrittten to Rust.
Nothing converts byte slices into addresses: the client builds them from a fixed-size array and the store parses them from hex.
vawale
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup ahead of the remote cache work. First of three stacked PRs. There are no functional changes