Skip to content

merge dev to main (v3.10.3) - #2927

Merged
ymc9 merged 2 commits into
mainfrom
dev
Nov 19, 2026
Merged

ymc9 merged 2 commits into
mainfrom
dev

Conversation

@ymc9

@ymc9 ymc9 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved Better Auth adapter handling for updates and deletes with compound, non-unique, and unmatched filters. Operations now return the expected results when records are missing.
  • Tests
    • Added database-backed coverage for adapter updates and deletes, including transactions and compare-and-swap scenarios.
  • Release
    • Updated packages from version 3.10.2 to 3.10.3.

github-actions Bot and others added 2 commits November 19, 2026 12:06
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
Co-authored-by: Yiming Cao <yiming@whimslab.io>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Better Auth adapter now handles compound filters for update and delete operations. Database-backed tests cover these cases and related update and delete behavior. Package versions change from 3.10.2 to 3.10.3.

Changes: Better Auth adapter compound filters

Layer / File(s) Summary
Filter conversion and update/delete behavior
packages/auth-adapters/better-auth/src/adapter.ts
Shared helpers convert where conditions and identify single-field unique filters. Updates without a recognized unique filter find a matching row and update by ID with the original filter as a guard. Deletes without one use deleteMany. Both operations only suppress ORM not-found errors.
Database-backed adapter tests
packages/auth-adapters/better-auth/test/*, packages/auth-adapters/better-auth/package.json
Tests cover compound, unique, non-unique, OR, compare-and-swap, transaction, and unmatched operations. The package adds @zenstackhq/testtools as a development dependency.
Release version alignment
package.json, packages/*/package.json, samples/*/package.json, tests/*/package.json, tests/runtimes/*/package.json
The listed root, package, sample, and test package versions change from 3.10.2 to 3.10.3.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Possibly related issues

  • zenstackhq/zenstack#2694 — The issue describes compound where conditions being rejected in the Better Auth adapter’s update() path, which this change modifies.

Possibly related PRs

  • zenstackhq/zenstack#2901 — This PR changes the Better Auth adapter’s handling of compound where conditions in update and delete operations.
Merge Risk: Minimal · up to e839e

This release adds support for compound filters in Better Auth update and delete operations and bumps package versions to 3.10.3. No concrete merge-blocking issue remains after review.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "merge dev to main (v3.10.3)" names only a branch merge and a version number. It does not describe the main functional change, which is Better Auth adapter support for compound where clauses… Replace the title with a sentence that names the primary change. For example: "Support compound where clauses in Better Auth adapter update and delete (v3.10.3)". Keep the version tag if the team uses it for release merges.
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "merge dev to main (v3.10.3)" names only a branch merge and a version number. It does not describe the main functional change, which is Better Auth adapter support for compound where clauses in update and delete operations. The title is generic and gives a teammate scanning history little information about the primary change.

Resolution

Replace the title with a sentence that names the primary change. For example: "Support compound where clauses in Better Auth adapter update and delete (v3.10.3)". Keep the version tag if the team uses it for release merges.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/auth-adapters/better-auth/package.json

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

packages/auth-adapters/better-auth/src/adapter.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

packages/auth-adapters/better-auth/test/adapter-db.test.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

  • 16 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 80b40ca and e839e34.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 30

  • package.json
  • packages/auth-adapters/better-auth/package.json
  • packages/auth-adapters/better-auth/src/adapter.ts
  • packages/auth-adapters/better-auth/test/adapter-db.test.ts
  • packages/cli/package.json
  • packages/clients/client-helpers/package.json
  • packages/clients/fetch-client/package.json
  • packages/clients/tanstack-query/package.json
  • packages/common-helpers/package.json
  • packages/config/eslint-config/package.json
  • packages/config/tsdown-config/package.json
  • packages/config/typescript-config/package.json
  • packages/config/vitest-config/package.json
  • packages/create-zenstack/package.json
  • packages/ide/vscode/package.json
  • packages/language/package.json
  • packages/orm/package.json
  • packages/plugins/policy/package.json
  • packages/plugins/soft-delete/package.json
  • packages/schema/package.json
  • packages/sdk/package.json
  • packages/server/package.json
  • packages/testtools/package.json
  • packages/zod/package.json
  • samples/orm/package.json
  • samples/taskforge/package.json
  • tests/e2e/package.json
  • tests/regression/package.json
  • tests/runtimes/bun/package.json
  • tests/runtimes/edge-runtime/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@ymc9
ymc9 merged commit c2f6dcf into main Nov 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants