feat(indexing): execute partitions with their reader context - #4349
Draft
d-v-b wants to merge 14 commits into
Draft
feat(indexing): execute partitions with their reader context#4349d-v-b wants to merge 14 commits into
d-v-b wants to merge 14 commits into
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Correct mathematical API documentation to match supported coordinate, grid, and chunk projection contracts. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Retain the existing unsigned selector fix and update the unsupported mixed-dependency error assertion for general intersection routing. Assisted-by: Codex:GPT-6
…oundaries Assisted-by: Codex:GPT-6
Use lexicographic tuple grouping when chunk indices contain negative values. Cover shared one-axis and two-axis array dependencies, repeated points, and extreme signed coordinates. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
github-actions
Bot
added
the
needs release notes
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Documentation build overview
24 files changed ·
|
Remove implementation history and unsupported historical claims from source and test docstrings. Distinguish immutable coordinate mappings from mutable source values. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Depends on #4345. This draft targets upstream
main, so its diff includes the prerequisite audit commits until that PR merges. Follow-up-only diff.Add
Partition.result()so independently scheduled partition reads receive the sameReadContextas parent assembly: the part's global transform and its existing chunk projection. Previously, the documentedpart.view.result()pattern supplied no projection and failed for readers that require one.The new method allocates through the view's existing output-buffer helper, invokes its reader without replanning, and preserves reader return validation and exception propagation. General
part.view.result()behavior is unchanged. Documentation and executable NumPy/Dask examples now usepart.result()for partition execution.Extend the existing reader contract matrix with a reader that evaluates chunk-local coordinates and requires the projection. Check parent assembly against independently executed parts in reverse order for scalars, positive/negative strides, repeated indices, orthogonal/vectorized gathers, and empty selections. Also exercise invalid reader returns and unchanged backend exceptions through both APIs. Six matrix cases failed before implementation.
Validation: 1,523 package tests/doctests passed, including optional Dask/TensorStore checks; strict docs build passed; applicable repository checks passed; Pyright reports 0 errors and 90 warnings. Independent review found no actionable issues.
Concurrent execution still requires a source and reader that support concurrent calls.
Corresponding fork review: d-v-b#337.
All four final follow-up heads were also combined and verified together: 1,633 package tests/doctests passed, no skips, and the strict documentation build passed.