Conversation
Contributor
Author
|
@TomNicholas, @aladinor let me know how this looks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
==========================================
+ Coverage 93.49% 94.34% +0.84%
==========================================
Files 88 92 +4
Lines 11873 12940 +1067
==========================================
+ Hits 11101 12208 +1107
+ Misses 772 732 -40
🚀 New features to boost your workflow:
|
Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Adds public
zarr.run, a synchronous bridge that runs a coroutine on Zarr's managed event loop by default, or on an explicitly supplied loop, and returns its result.It translates the internal SyncError to RuntimeError when called from the target loop's thread. Unlike asyncio.run, it does not reject every running loop: a different active loop on the calling thread permits dispatch, although that thread is blocked. Async callers should normally await the async API directly.
Documentation and a regression test distinguish those cases. Audit validation:
hatch run test.py3.12-minimal:pytest tests/test_sync.py -q— 27 passed; commit hooks passed. Existing timeout tests emit pending-task destruction diagnostics because this branch's sync timeout does not cancel the submitted coroutine.