test(intent-engine): cover GMX deposit slippage boundaries - #582
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
vercel
Bot
temporarily deployed
to
Preview – zap-engine-control-center
September 16, 2026 23:48
Inactive
vercel
Bot
temporarily deployed
to
Preview – zap-engine-control-center
September 16, 2026 23:56
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage diagnosis
The baseline coverage HTML marked both line 61 and line 71 as
if path not taken, confirming the missing side was the validation/error path rather than requiring a guess about individual||operands.Verification
coverage-handoffforsrc/builders/gmx-v2-supply.builder.tsnow reports only uncovered lines145,159and branch lines144,15661/62/71/76gaps are coveredThe local shell/DevSpace connector was unavailable in this session, so the literal scoped command
pnpm turbo run test:coverage --filter=@zapengine/intent-enginecould not be executed locally. The repository's CI coverage job ran workspace-wideturbo run test:coverage(including@zapengine/intent-engine) successfully and produced the canonical coverage artifact used for the confirmation above.