Skip to content

test(intent-engine): cover GMX deposit slippage boundaries - #582

Merged
i-xtsu-sixyou-ken-mei merged 3 commits into
mainfrom
test/intent-coverage-gmx-slippage
Sep 17, 2026
Merged

i-xtsu-sixyou-ken-mei merged 3 commits into
mainfrom
test/intent-coverage-gmx-slippage

Conversation

@i-xtsu-sixyou-ken-mei

@i-xtsu-sixyou-ken-mei i-xtsu-sixyou-ken-mei commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add isolated coverage tests for GMX v2 supply deposit slippage validation
  • cover 0/1 wei-style estimated GM-token outputs that cannot preserve a slippage buffer
  • cover omitted/default slippage plus fractional, zero, and above-max invalid slippage values
  • leave production behavior, constants, thresholds, and coverage ignores unchanged

Coverage diagnosis

The baseline coverage HTML marked both line 61 and line 71 as if path not taken, confirming the missing side was the validation/error path rather than requiring a guess about individual || operands.

Verification

  • latest GitHub Actions coverage job: passed
  • latest test, quick-gates/format, code-quality, e2e, security, and deploy-gates jobs: passed
  • latest coverage-handoff for src/builders/gmx-v2-supply.builder.ts now reports only uncovered lines 145, 159 and branch lines 144, 156
  • therefore the requested 61/62/71/76 gaps are covered

The local shell/DevSpace connector was unavailable in this session, so the literal scoped command pnpm turbo run test:coverage --filter=@zapengine/intent-engine could not be executed locally. The repository's CI coverage job ran workspace-wide turbo run test:coverage (including @zapengine/intent-engine) successfully and produced the canonical coverage artifact used for the confirmation above.

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
zap-engine-control-center Skipped Skipped Sep 16, 2026 11:56pm UTC

@vercel
vercel Bot temporarily deployed to Preview – zap-engine-control-center September 16, 2026 23:48 Inactive
@vercel
vercel Bot temporarily deployed to Preview – zap-engine-control-center September 16, 2026 23:56 Inactive
@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei merged commit d6e8d23 into main Sep 17, 2026
16 checks passed
@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei deleted the test/intent-coverage-gmx-slippage branch September 17, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant