[test-qa-hourly] test: cover waitlist signup pagination boundary

[i-xtsu-sixyou-ken-mei]

Intent

Continue continuous QA on the reusable test-qa/ongoing-coverage-20260909 branch with one small regression-focused test around Control Center waitlist attribution pagination.

Inspection

• Previous QA head b8a6d5be320f5cdcc637f401970242edc4123582 passed CI run #2426 (34307650078).
• main advanced to b2e3dec2348e382f750c5d748f9df716283a30f1 via the daily track-record snapshot; the QA branch was safely synced with that commit before this run's test change.
• Open PRs were inspected; PR [test-qa-hourly] test: cover waitlist signup pagination boundary #427 remains the reusable QA PR and has the test-qa label.
• apps/control-center/src/server/services/waitlist-growth.ts uses PAGE_SIZE = 500 for signups, canonical jobs, and social_post_metrics; metric rows are ordered ascending by captured_at/id and later rows overwrite earlier rows in the views map.
• .github/workflows/ci.yml still runs quick gates (format repo contracts), code-quality (type-check lint deadcode dup), tests (test analytics), E2E, security, and deploy gates.
• Coverage remains available through scripts/coverage.sh summary -> turbo run test:coverage + scripts/coverage-summary.ts.

QA changes

Existing change in this PR:

• 501-signup snapshot regression crossing the 500-row signup pagination boundary.

This run:

• Added waitlist-growth-metrics-pagination.test.ts with 501 collected 24h metric snapshots for one social post.
• The first 500 snapshots live on page 1 and a newer snapshot lives on page 2.
• Pins that the newest snapshot still wins (views24h = 999, signupRate = 1 / 999).
• Pins metric page ranges 0..499, 500..999, then completion probe from 501..1000.

No implementation, workflow, docs, ignore, threshold, or agent-instruction changes were made in this run.

Validation / commands and results

• GitHub CI on previous head — PASS: CI #2426 completed successfully.
• Repository implementation review of waitlist-growth.ts — PASS: metric pagination is PAGE_SIZE = 500, ascending captured_at ordering, map overwrite semantics preserve newest snapshot.
• .github/workflows/ci.yml inspection — PASS: existing gates unchanged.
• scripts/coverage.sh inspection — PASS: coverage aggregation path remains available.
• PR changed-file review — PASS: current diff is limited to tests/test config plus the prior formatting-only CI fixes.
• Local focused validation attempt: git clone --depth 1 --branch test-qa/ongoing-coverage-20260909 https://github.com/zapPilot/zapEngine.git /tmp/zapengine-qa && corepack enable && pnpm --version && pnpm install --frozen-lockfile --prefer-offline — BLOCKED before install because the execution container cannot resolve github.com (Could not resolve host: github.com). No local test command could be run from that container.
• Updated-head GitHub Actions CI #2428 (34311458624) — QUEUED. This will execute the repository-authoritative quick gates, typecheck/lint/deadcode/dup, tests, E2E, security, deploy gates, and coverage-related test paths configured by CI.

Scope guard

Current PR files:

• apps/app/tests/useInvestExecution.contract.test.tsx — prior formatting-only CI fix
• apps/app/vitest.config.ts — prior formatting-only CI fix
• apps/control-center/src/server/services/waitlist-growth-batching.test.ts — QA regression tests
• apps/control-center/src/server/services/waitlist-growth-metrics-pagination.test.ts — this run's QA regression test
• apps/control-center/vitest.config.ts — prior formatting-only CI fix
• apps/landing-page/vitest.config.ts — prior formatting-only CI fix
• packages/app-core/vitest.config.ts — prior formatting-only CI fix

Auto-merge

Not enabled yet. PR is open, non-draft, mergeable, correctly titled/labeled/branched, and scope is QA-safe; blocker is updated-head CI #2428 not yet green.

Next QA target

After this PR is green, inspect concurrent snapshot mutation around metric pagination: page 1/page 2 duplication or disappearance should not silently produce a plausible but stale conversion rate.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
zap-engine-control-center	Skipped		Sep 9, 2026 4:33am UTC

[i-xtsu-sixyou-ken-mei]

QA run update — 2026-09-09

CI-first run. No new regression test added because the previous head failed CI.

Inspection

• Reused this open QA PR ([test-qa-hourly], branch test-qa/ongoing-coverage-20260909).
• Current main: e80f9182bcee7c334f5ab4998ee46dc1239e967b.
• Previous head 62485fc5dfe6992f1274c3827b7b18ebc56ebbea: CI #2421 (34303891849) failed.
• Job inspection: quick-gates failed; code-quality, security, coverage, and tests passed.
• Downloaded quick-gates-verify-1 artifact and inspected result.json plus logs/format.log.
• Exact artifact result: repo PASS, contracts PASS, format FAIL.
• Prettier diff identified five inherited formatting issues from current main: apps/app/tests/useInvestExecution.contract.test.tsx plus missing final newlines in four Vitest config files.

Action

Applied only the canonical Prettier output required to clear the failing gate:

• apps/app/tests/useInvestExecution.contract.test.tsx
• apps/app/vitest.config.ts
• apps/control-center/vitest.config.ts
• apps/landing-page/vitest.config.ts
• packages/app-core/vitest.config.ts

No behavior, thresholds, workflow, docs, ignore rules, or product implementation changed. Existing pagination regression remains unchanged.

Commands / results

• GitHub CI run #2421 job inspection — FAIL isolated to quick-gates.
• quick-gates-verify-1/result.json — format=failed, repo=passed, contracts=passed.
• quick-gates-verify-1/logs/format.log — canonical Prettier diff captured and applied exactly.
• PR changed-file review — now 6 files total: the existing pagination test + 5 minimal formatting-only CI fixes.
• Updated-head CI #2426 (34307650078) — pending at time of this update.

Auto-merge

Not enabled yet: updated-head CI must be green first.

Next QA target

Once CI is green, cover the 500-row social_post_metrics pagination boundary, especially an older/newer snapshot for the same post split across pages so newest captured_at still wins.