Conversation
Co-authored-by: Sal <ss-o@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion readiness record
Candidate identity
Prior
mainSHA:86758198344052d60b25f454cd3b64269a8ef2eaCandidate
nextSHA:8104e93f651812fc3f6bcb03284b921bbd178e1aCandidate tree SHA:
9bac22bf2c03ec5f82feef8ba13e28ce573a65faComplete compare:
main...nextgit diff --name-only 8104e93...8675819produces no output.git rev-parse '8104e93^{tree}'equals9bac22bf2c03ec5f82feef8ba13e28ce573a65fa.git log --oneline 8104e93..8675819is not empty this time: it contains exactly one commit,8675819 chore: promote next to main (#494), which is the previous promotion merge and exists only onmainby design. The template calls this out. No stable-only content commit is stranded, and the empty three-dot diff is the precondition that matters.Required validation
Zsh syntax and compileZD integrationTrunkCodeQLClean install and startupPromotion gate8675819, head8104e93.Guard main branch sourceandPromotion gaterequired contexts pass. 24 checks green, none failing or skipped.Readiness review
Why now
maincannot publish a release. The publish job inrelease.ymlrunszsh -f scripts/verify-release-tag.zshonubuntu-latest, which ships no Zsh, so it exits 127 before verifying anything. Taggingv2.0.1was that workflow's first ever execution, since it reachedmainonly with #494, and it failed on that run. v2.0.1 was published manually after running the verifier locally against the exact tag.Until this promotion lands, any new tag on
mainfails the same way. That is the whole reason for promoting a single CI commit rather than waiting to batch it.Contents
One commit, #497, adding a Zsh install step to the publish job before the verification step. No change to
zi.zsh, any library, or any consumer-visible surface.Unresolved issues
None blocking. Open zi issues are unchanged from the previous promotion and none is a regression from this candidate.
User-facing and migration notes
None. This candidate touches only
.github/workflows/release.yml. Runtime behaviour is identical to v2.0.1.Public-contract follow-ups
None. The candidate contains no shell source change.
Merge contract
Promotion uses Create a merge commit. Never squash or rebase.
Co-authored-bytrailer.delete_branch_on_mergeisfalse; remotenextwill survive the merge.mainruleset allows only merge commits and does not require linear history.nextruleset does not require linear history.Rollback readiness
@ss-oReleaseworkflow fails on a subsequent tag, or the publish job behaves differently from a local run ofscripts/verify-release-tag.zsh.hotfix-*pull request that reverts the promotion merge through protectedmain.Guard main branch sourceandPromotion gate.mainhead, then the hotfix will be merged forward intonext.Stable consumption boundary
This updates the Git-consumed stable
mainref. It creates no semantic tag or GitHub release. v2.0.1 remains the newest tag and its content is unchanged by this promotion, which adds only a workflow step.