chore(contract): record the complete message-output consumer set - #464
Merged
Conversation
The manifest listed two consumers of the message-output surface. A direct search of the organization finds five consumer files across two repositories. Add the three missing entries and refresh evidence_reviewed: z-shell/wiki docs/guides/syntax/01_standard.mdx z-shell/wiki community/05_gallery/collection/03_programs.mdx z-shell/src public/zsh/snippets/welcome.zsh Each was verified to contain +zi-message usage at its pinned commit, and scripts/public-contract-evidence.zsh reports all three pins current. z-shell/src was already listed for installer-git-output only; its welcome snippet is a separate dependency on message-output. This matters for the pending promotion: e50d19e changes the emitted bytes of every message, and scoping that against the manifest alone would have covered two of five consumer files. Closes #463
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the three missing
message-outputconsumers incontracts/public-contract-v1.jsonand refreshesevidence_reviewed.Closes #463
Problem
The manifest listed two consumers of the
message-outputsurface. A directsearch of the organization finds five consumer files across two repositories.
The registry exists so a breaking change to a public surface can be scoped
cheaply and completely.
e50d19e(feat!: rebuild message output with safe auto formatting, #457) changes the emitted byte stream of every message and is partof the pending
nexttomainpromotion. Scoping it against the registry alonewould have covered two of five consumer files.
Change
z-shell/wikidocs/guides/syntax/01_standard.mdx3c56c281z-shell/wikicommunity/05_gallery/collection/03_programs.mdx5f3450cbz-shell/srcpublic/zsh/snippets/welcome.zsha715c1d0z-shell/srcwas already listed forinstaller-git-outputonly. Its welcomesnippet is a separate dependency on
message-output.z-shell/z-a-meta-plugins/tests/prezto-meta-plugin.zshdefines a local stub+zi-message() { :; }. That is a test double, not a consumer, and isdeliberately excluded.
Verification
Each path was fetched from the GitHub API at its proposed pin and confirmed to
contain the usage, rather than relying on a local checkout:
zsh scripts/public-contract-evidence.zshreports all three new pinscurrent.zsh tests/public-contract-impact.zshpasses, includingconsumer evidence must be complete and SHA-pinnedandevidence URLs must match their declared repository and path.trunk checkreports no issues.Out of scope
The evidence detector reports five pre-existing stale pins unrelated to this
surface:
A stale pin is a review signal, not automatically a contract break. Re-reading
each consumer and bumping its pin is separate work.