fix(decisions): stop crediting AI agents as decision-record deciders - #577
Merged
Conversation
Four accepted records listed an automation identity in `Deciders`: - 0004 "ss-o, Gemini CLI" - 0005 "ss-o, Claude Code" - 0006 "ss-o, Claude Code" - 0007 "ss-o, Claude Code" That contradicts organization policy, which bans crediting a bot or AI agent as a co-author, and runbooks/adr.md, which reserves decision authority for a maintainer. An agent may draft a record; it never decides one. In each case ss-o was the actual decider, so the agent is dropped rather than the record rewritten. Prose alone would drift back, so scripts/decision-records.py now rejects an automation identity in `Deciders`. This is the decision-record half of the rule the commit-msg hook already enforces for commit trailers. The pattern matches `[bot]` suffixes and known agent product names, and the check runs in CI with the rest of the record contract. Also fixes a pre-existing black formatting failure in scripts/test_validate_zsh_standard_policy.py, and a pre-existing prettier emphasis-style drift in ADR 0006. Neither was caught before because the CI lint job only scans files changed by a pull request, so a latent finding in an untouched file never surfaces until something else edits that file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four accepted decision records credited an automation identity in
Deciders:ss-o, Gemini CLIss-oss-o, Claude Codess-oss-o, Claude Codess-oss-o, Claude Codess-oThis contradicts two existing rules. Organization policy bans crediting a bot or AI agent as a co-author, enforced for commit trailers by the
commit-msghook inscripts/git-hooks. Andrunbooks/adr.mdreserves decision authority for a maintainer: an agent may draft a record, it never decides one.In each case
ss-owas the actual decider, so the agent is dropped rather than the record rewritten. No decision content changed.This was surfaced by the decision index added in #576 — putting all 21 records in one table made the four outliers visible immediately, which is the kind of drift the index exists to catch.
Enforcement
Prose alone would drift back, so
scripts/decision-records.pynow rejects an automation identity inDeciders. This is the decision-record half of the rule thecommit-msghook already enforces for commit trailers, matching[bot]suffixes and known agent product names. It runs in CI with the rest of the record contract.Verified the check flags exactly the four known records and nothing else before correcting them, so the pattern is not over-broad.
test_allows_human_deciderspins that a multi-humanDecidersvalue stays valid.Pre-existing defects also fixed
Both were latent because the CI lint job only scans files changed by a pull request, so a finding in an untouched file never surfaces until something else edits that file.
scripts/test_validate_zsh_standard_policy.pyfailedblackon a clean checkout ofmain. Reported in docs(decisions): accept ADRs 0018, 0020, 0021 and enforce the record contract #576; fixed here.decisions/0006-wiki-content-root-boundaries.mdhadprettieremphasis-style drift (*implementation*to_implementation_), surfaced because this change touches that file.Worth noting: a whole-repository
trunk check --allreports roughly 70 further findings across 288 files, all in files untouched by this change. That backlog is out of scope here and would need its own cleanup pass.Verification