Skip to content

Address HACS review feedback - #7

Merged
yoali11 merged 1 commit into
mainfrom
address-hacs-review
Oct 19, 2026
Merged

yoali11 merged 1 commit into
mainfrom
address-hacs-review

Conversation

@yoali11

@yoali11 yoali11 commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Addresses the non-blocking feedback from @frenck's review in hacs/default#9947.

Changes

  • Real webhook URLs in the config flow: the setup form and notification now use the same get_url-based helper as webhook.py, instead of an https://INSERT_URL/ placeholder.
  • Prefer the external URL: Clockify calls the webhooks from the internet, so the external URL is used ahead of the internal one.
  • Placeholder fallback explained: if Home Assistant has no URL configured, the URLs fall back to https://INSERT_URL/, and the form and README tell users to replace it.
  • Manifest: added webhook to dependencies and bumped version to 1.1.4.
  • README: removed the custom-repository install step and switched the badge to HACS Default.

After merge

Tag and release v1.1.4 to match the manifest version.

🤖 Generated with Claude Code

- Show the real webhook URLs in the config flow and setup notification
  using Home Assistant's external URL, instead of an INSERT_URL placeholder
- Prefer the external URL, since Clockify calls the webhooks from the internet
- Explain the INSERT_URL fallback in the form and README
- Add webhook to manifest dependencies and bump version to 1.1.4
- Update README install steps now that the integration is in default HACS

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yoali11
yoali11 force-pushed the address-hacs-review branch from dc13a78 to bfd57d7 Compare October 19, 2026 19:37
@yoali11
yoali11 merged commit 52f7a18 into main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant