Skip to content

Add tests for yiisoft/db#1204 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjik merged 1 commit into from
Oct 14, 2026
Merged

Add tests for yiisoft/db#1204 #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/QueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Expression\Function\ArrayMerge;
use Yiisoft\Db\Expression\Value\Param;
use Yiisoft\Db\Expression\Value\Identifier;
use Yiisoft\Db\Query\Query;
use Yiisoft\Db\Query\QueryInterface;
use Yiisoft\Db\Query\WithQuery;
Expand Down Expand Up @@ -810,4 +811,27 @@ public function testArrayMergeWithOrdering(): void

$this->assertEquals('[1,2,3,4,5,6,7,9,10]', $result);
}

public static function dataBuildIdentifier(): iterable
{
yield ['name', '"name"'];
yield ['t.name', '"t"."name"'];
yield ['s.t.name', '"s"."t"."name"'];
yield [['t', 'na.me'], '"t"."na.me"'];
yield ['LOWER(name)', '"LOWER(name)"'];
yield ['[[name]]', '"[[name]]"'];
yield ['{{%t}}.name', '"{{%t}}"."name"'];
yield ['*', '"*"'];
yield ['arr[1]', '"arr[1]"'];
yield ['a"b', '"a""b"'];
yield ['"a" DESC; DROP TABLE t; --', '"""a"" DESC; DROP TABLE t; --"'];
}

#[DataProvider('dataBuildIdentifier')]
public function testBuildIdentifier(string|array $name, string $expected): void
{
$qb = $this->getSharedConnection()->getQueryBuilder();

$this->assertSame($expected, $qb->buildExpression(new Identifier($name)));
}
}
7 changes: 7 additions & 0 deletions tests/QueryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,11 @@ public function testLikeCaseSensitive(mixed $expected, string $value): void
$this->expectExceptionMessage('SQLite doesn\'t support case-sensitive "LIKE" conditions.');
$query->scalar();
}

public static function dataIdentifierColumnName(): iterable
{
yield from parent::dataIdentifierColumnName();
yield 'quote: a"b' => ['a"b'];
yield 'quote: "a"' => ['"a"'];
}
}
Loading