Repository navigation
Add tests for yiisoft/db#1204 - #486
Merged
Merged
Conversation
vjik
commented
Oct 13, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage 99.10% 99.10%
Complexity 258 258
=========================================
Files 25 25
Lines 786 786
=========================================
Hits 779 779
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused tests correctly cover MySQL identifier quoting and pass across the supported database matrix.
0 open findings
What changed in this PR
Adds MySQL-specific coverage for the strict Identifier expression introduced by yiisoft/db#1204.
Changes:
- Tests backtick escaping in query execution.
- Tests strict identifier building across common edge cases.
| File | Description |
|---|---|
tests/QueryTest.php |
Adds MySQL backtick identifier cases. |
tests/QueryBuilderTest.php |
Verifies strict identifier SQL generation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.