Repository navigation
ci: switch /ai-review to the shared multi-model review - #1032
Open
MauroToscano wants to merge 5 commits into
Open
MauroToscano wants to merge 5 commits into
MauroToscano wants to merge 5 commits into
Conversation
/ai-review (and the ai-review* labels) now call pr_review_multi.yml from yetanotherco/actions: Opus, GPT, Kimi, GLM and DeepSeek review the PR as read-only agents, a judge checks every finding against the code, and one comment is posted with the findings, housekeeping notes and the cost. '/ai-review continue' finishes a budget-limited review and '/ai-review budget=N' raises the budget. The repository's review config (.github/ai-review/config.toml and threat_model.md) replaces the opencode swarm's matrix and prompts, which are removed with its runner, tests and opencode config.
Pin pr_review_multi.yml to the commit with the review fixes. The docs now give the enforced soft budgets, say the config is read from the PR's base branch, that Opus is billed by Anthropic outside the OpenRouter limit, and list the changes from the previous review. The config's priority list is narrowed to the soundness-critical code, with the VM and syscalls no longer reviewed last.
3 of 14 tasks
Pins yetanotherco/actions b265aff, which adds #25 (files lost when a split area was chunked) and the fixes from a second review: failed reviewers and changed files no reviewer saw are listed in the comment, whitespace changes in Python, shell, YAML and Makefiles are reviewed, and odd file names or Rust test modules can no longer hide code. docs/ai-review.md says what changed for this repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/ai-review(and theai-review*labels) now call the shared multi-model review,pr_review_multi.ymlfrom yetanotherco/actions (yetanotherco/actions#24), pinned at that PR's latest commit,b265aff./ai-review continuefinishes a review that ran out of budget, and/ai-review budget=Nraises the budget.The review is steered by
.github/ai-review/config.toml(paths, review order) andthreat_model.md(what matters in a zkVM). Both are read from the PR's base branch.Removed. The opencode swarm:
.github/scripts/ai_review.py, its tests and test workflow, the matrix and prompts, and.opencode/.docs/ai-review.mdis rewritten and lists the changes from the previous review.What needs to be done
The full checklist is in yetanotherco/actions#24. For this repository:
1. Before the first run
OPENROUTER_API_KEYis a key from the OpenRouter account with theair-*presets, with a credit limit.ANTHROPIC_API_KEYsecret here belongs to an Anthropic workspace with a monthly spend limit. Opus is billed there.2. First run
ai-reviewlabel to this PR. Label events run this PR's version of the workflow.sandbox check: lane commands run, ...). If it fails, the review stops before any paid call, and the comment says why.mainhas no.github/ai-review/config.tomlyet, so this run uses the defaults: every file sensitive, no threat model. It reviews only CI files, so the findings themselves don't matter; the run tests the pipeline.3. Merge
uses:in.github/workflows/pr_ai_review.yamlfrom the branch commit (b265aff) to the release tag's commit./ai-reviewcomments work from then on, because comment triggers runmain's workflow. The config and threat model in.github/ai-review/apply to every review after that.Unrelated failing check
"Spec tests" fails here because
spec/tooling/chip.pybreaks on the newer Python on the runners: it reads__annotations__from an instance. That workflow last ran onmainin June, and this PR doesn't touchspec/.