Repository navigation
airplay: sync the volume both ways and light the ring on connect - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On speakers without capsule-mini-tweaker the AirPlay bundle leaves shairport-sync without metadata and with its own software volume. The airplay plugin then sees nothing: the ring stays dark, and the phone's slider attenuates the stream inside shairport-sync while the speaker's volume (shown on the display and in the panel) never changes.
/tmp/shairport-sync-metadata) andignore_volume_controlin/etc/shairport-sync.conf, then restart shairport-sync. An already tuned config is left alone.volumeevent (level,muted) on every volume change: voice, keys, panel, plugins. Plugins subscribe by kind, so existing ones are unaffected; documented in README and sdk/README.volume.seton the speaker (pvolmetadata, −30…0 dB ↔ 0…100%, −144 = mute);SetAirplayVolume(dbus-send), without echoing a change back to where it came from;/run/capsule-controls.sockpresent the bundle'sap2-bridgealready syncs the volume, so the plugin only lights the ring. Works together with agent: optional Capsula Mini volume via capsule-ipc #15.Tests: installer config tuning, dB ↔ level round trip for every level, echo suppression, the bridged case.
gofmt,go vet,go test -race,node --checkpass.Not tested on a real speaker yet.