Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved deployment defects reject matching versions due to CRLF line endings and package the plugin without required runtime dependencies.
5 open issues
What changed in this PR
Adds GitHub Actions workflows to automate releases and PHP formatting for the WordPress plugin.
Changes:
- Adds version checks, asset builds, WordPress.org deployment, and GitHub release creation, with a manual dry-run option.
- Runs PHP formatting on relevant pushes to
mainand commits changes automatically. - Defines release exclusions to keep development files out of distributed packages.
| File | Description |
|---|---|
.github/workflows/format-php.yml |
Automates PHP formatting and commits resulting changes. |
.github/workflows/deploy.yml |
Adds release validation, builds, deployment, and ZIP publishing. |
.distignore |
Excludes development files and tooling from release packages. |
Review effort: Balanced
| - name: Check the version numbers | ||
| run: | | ||
| PLUGIN_VERSION=$(grep -m1 -E '^\s*\*\s*Version:' yard-deepl.php | awk '{print $NF}') | ||
| STABLE_TAG=$(grep -m1 -E '^Stable tag:' readme.txt | awk '{print $NF}') |
YvetteNikolov
left a comment
YvetteNikolov
left a comment
There was a problem hiding this comment.
Overheen gescand, geen expert op workflows maar heb niks geks kunnen zien
| @@ -0,0 +1,79 @@ | |||
| name: Deploy to WordPress.org | |||
There was a problem hiding this comment.
Misschien een andere filename bedenken dan deploy.yml om verwarring met onze deploy workflow te voorkomen https://github.com/yardinternet/workflows/blob/main/.github/workflows/deploy.yml
57d5f27 to
32c662c
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The caller and reusable workflow share a concurrency group with cancellation enabled, causing automerge to cancel its own parent run instead of reliably completing the merge.
3 open issues
2 resolved since last review
Review effort: Balanced
d4591da to
223bd12
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The deployment workflow can reject valid releases due to classmap ordering differences and allows concurrent deployments of the same version to conflict during publication.
3 open issues
2 resolved since last review
Review effort: Balanced
| deploy: | ||
| name: Deploy new tag | ||
| runs-on: ubuntu-latest |
| exit 1 | ||
| fi | ||
| # Strauss stamps every file with the build date; ignore those lines. | ||
| if ! diff -r -I 'Modified by .* using' "$COMMITTED" vendor-prefixed; then |
No description provided.