Add versioning - #15
Open
varsameer wants to merge 1 commit into
Open
Conversation
uthiramohan
reviewed
Apr 28, 2022
|
|
||
| void HMState::setStateVersion(uint32_t version) | ||
| { | ||
| m_stateVersion = version; |
There was a problem hiding this comment.
Can you also include a check for uintmax_t
| HMTimeStamp checkTime = it->second.nextCheckTime(ip, version); | ||
| HM_WORK_STATE query_state = it->second.getQueryState(ip); | ||
| uint32_t query_version = it->second.getQueryVersion(ip); | ||
| if ( query_version != version ) { |
There was a problem hiding this comment.
for formatting can we have the brackets ({) in new line
uthiramohan
reviewed
May 4, 2022
| AF_INET), | ||
| HMDataHostCheck(it->first.second.getType()), | ||
| it->first.second)); | ||
| dnslookup->setReschedule(false); |
There was a problem hiding this comment.
Can you explain why reschedule is set to false
terrynfredrickson-yahoo
approved these changes
May 4, 2022
uthiramohan
reviewed
May 5, 2022
| currentState->m_checkList.queueCheck(m_hostname, *iit, check, m_stateManager->m_workQueue, getStateVersion()); | ||
| } | ||
| else{ | ||
| // We will hit this path after a reload for hosts |
uthiramohan
reviewed
May 5, 2022
| \return true if the check is expired and needs to be run now. | ||
| */ | ||
| bool queryNeeded() const; | ||
| bool queryNeeded(uint32_t version=0) const; |
There was a problem hiding this comment.
Can you create a constant HM_DEFAULT_STATE_VERSION = 0 in HMConstants.h and use it
uthiramohan
reviewed
May 5, 2022
|
|
||
| HM_SCHEDULE_STATE | ||
| HMDataCheckList::checkNeeded(string& hostname, HMIPAddress& ip, HMDataHostCheck& hostCheck) | ||
| HMDataCheckList::checkNeeded(string& hostname, HMIPAddress& ip, HMDataHostCheck& hostCheck, uint32_t version) |
There was a problem hiding this comment.
can you add the default parameter like in header uint32_t version = HM_DEFAULT_STATE_VERSION / 0
uthiramohan
reviewed
May 5, 2022
| currentState->m_dnsCache.queueDNSQuery(data->m_hostname, | ||
| data->m_dnsHostCheck, | ||
| state->m_workQueue); | ||
| state->m_workQueue, |
There was a problem hiding this comment.
addDNSTimeout, addHealthCheckTimeout functions are not overloaded
uthiramohan
reviewed
May 5, 2022
| data->m_dnsHostCheck, | ||
| state->m_workQueue); | ||
| state->m_workQueue, | ||
| state->getStateVersion()); |
There was a problem hiding this comment.
state doesnn't have function getStateVersion() , did you mean currentState->getStateVersion()
uthiramohan
reviewed
May 5, 2022
| data->m_address, data->m_hostCheck, | ||
| state->m_workQueue); | ||
| state->m_workQueue, | ||
| state->getStateVersion()); |
uthiramohan
requested changes
May 5, 2022
uthiramohan
left a comment
uthiramohan
left a comment
There was a problem hiding this comment.
New tag ll be released once the reviews are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds versioning changes to the state
Description
After quick consecutive reloads, the workQueue gets filled up with multiple work orders for the same hostname( spawned by states belonging to previous reloads) . This change adds a version to each state and increments it on each reload. With this change, after every check is done, the version of the check is compared with the current state version to see if the check belongs to a previous state and is discarded if so.