Make changes - #11
Open
tkraiser-arista wants to merge 8 commits into
Open
Conversation
Change test files so it can compile for slim-builds
- HMStorageObserver can be extended and don't affect NetCHASM code.
Fix code that is formatting int64_t as %u for 32 bits platforms
Get rid of signal action initializations Make routine non blocking. Shutdown routine can be called standalone.
curl_global_init is called from curl_easy_init and is not thread-safe. Since NetCHASM has multiple threads calling curl_easy_init we hit at least in one of our stress tests a double-free on the stack call of curl_global_init. We could see from the core that other threads were executing curl calls while the thread that hit the double-free was still finishing the curl_global_init.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Makefiles to not hard-code bin64/lib64. Use GNUIncludes to find the right architecture.
Don't use hard-coded CMAKE_INSTALL_PREFIX. Pass it via the Makefile. That allows people using different destination install prefixes to call cmake passing their own defaults.
Change tests so they can be run with slim-build defines.
Related Issue
Motivation and Context
Allows netchasm to be linked as a 32-bit platform and the installation to reach the right directories.
Allows unit tests to be run when slim-build defines are used.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: