Skip to content

The auto-merge guard comment implies its author clause is forgeable #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xroche merged 3 commits into from
Sep 1, 2026
Merged

The auto-merge guard comment implies its author clause is forgeable #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6533a85
Stop ranking the two clauses of the auto-merge guard
xroche Sep 1, 2026
37ca68d
Say what the head-repo clause is for, not that it cannot fire
xroche Sep 1, 2026
9c63653
Give each clause of the auto-merge guard its own reason
xroche Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dependabot-automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ permissions:
jobs:
automerge:
name: Arm auto-merge
# github.actor is the pusher, not the author, so a dependabot push onto a fork PR can
# satisfy it. The head-repo clause is the one that cannot be forged.
# github.actor names whoever triggered the event, so the author check reads user.login.
# The head-repo clause makes dependabot's same-repo branches a precondition, not an assumption.
if: >-
github.repository == 'xroche/httrack-android'
&& github.event.pull_request.user.login == 'dependabot[bot]'
Expand Down
Loading