Bump to 3.50.0 final (versionCode 101), engine 3.50.0 - #173
Merged
Conversation
Ends the beta suspension of the version rule: the versionName prefix is the pinned engine's HTTRACK_VERSIONID again, with versionCode as the fourth part, so a tester report names both the build and the engine. Engine 26f24acb (3.49.24) to 32265631 (3.50.0). src/Makefile.am's build list is unchanged, so Android.mk's hand-maintained source list needs no edit and no new command-line option needs GUI plumbing; the release commit touches htsglobal.h alone among sources Android compiles. distribution/whatsnew still describes beta 8. play-promote.yml re-reads it, so the notes are rewritten before this leaves internal rather than here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Ten prior version bumps updated distribution/whatsnew in the same commit as the version itself, and play-publish.yml passes whatsNewDirectory from the tagged tree. So tagging the bump alone would have shipped "HTTrack 3.50 beta 8" and "Updated to the HTTrack 3.49.24 engine" to internal testers. Deferring them to play-promote.yml, as the previous commit said, covers promotion only. Written for a reader coming from the 2017 build that production still serves, not for the delta since beta 8. Source text and the measured character budget are in httrack-works android-release/. The About-box comment's example died with this bump: a 3.50 app can no longer ride a 3.49 engine. Restated as the rule it was there to illustrate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.50 final. The engine pin moves to the 3.50.0 release squash, and versionName returns to the rule the beta suspended: the prefix is the pinned engine's HTTRACK_VERSIONID, with versionCode as the fourth part. Xavier chose that over a bare
3.50, because a tester reporting3.50.0.101names the build and the engine in one string.Verified at the pin rather than taken from the engine session:
HTTRACK_VERSIONID "3.50.0",HTTRACK_VERSION "3.50-0",AC_INIT3.50.0. The delta from4be1224f, checked earlier, is the release commit by itself, and the only source it touches that Android compiles ishtsglobal.h. Worth knowing thatgit describe --tagson this pin reports3.49.25-2-g32265631, so a bump driven off it would have produced3.49.25.101and nothing in CI would have caught it.prebump-check.sh 26f24acb 3226563is clean:src/Makefile.am's build list is unchanged, soAndroid.mk's hand-maintained source list needs no edit, and no new command-line option needs GUI plumbing. That script refuses to compare a pin with itself, so it cannot pass vacuously.distribution/whatsnewis rewritten here as well, in all 29 locales. Ten prior bumps updated it in the same commit as the version, andplay-publish.ymlpasseswhatsNewDirectoryfrom the tagged tree, so tagging the bump alone would have shipped "HTTrack 3.50 beta 8" and "Updated to the HTTrack 3.49.24 engine" next to a 3.50.0 final. The notes address a reader coming from the 2017 build that production still serves, rather than the delta since beta 8.Nothing else in the tree asserts the old version string, and no unit test reads versionName or versionCode. The About-box comment citing a 3.50 beta on a 3.49 engine is restated, since this bump killed its example.
This goes to Play internal only. Nothing promotes past internal, and nothing is tagged, before 1 September.