Repository navigation
Add fixes for security warnings - #5
Merged
Merged
Conversation
RestoreElectronBinary shelled out to Windows PowerShell 5.1, which fails when the build inherits a PowerShell 7 PSModulePath (Expand-Archive MethodCountCouldNotFindBest). The old target deleted dist first, leaving it empty and the Electron window never opening. Locate the cached zip with an item glob and extract it with the built-in Unzip task instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… only Linux restore was working, so restore its find/unzip/chmod steps exactly. The MSBuild glob + Unzip path now applies only to Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…pgww-w46g-26qg) bunit 2.7.2 pulls in AngleSharp 1.4.0 transitively; 1.5.0 is the first patched version. A direct reference overrides the transitive one. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LoadUserData dereferenced currentOrgId with ! and let a null active org surface as 'Nullable object must have a value'. Check HasValue and set a specific message, and render errorMessage in the !canViewUser branch so it is not hidden behind the generic Access Denied text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The local currentUserRole in LoadUserData shadowed the field, so the role input always rendered the field default. Rename the local to actingUserRole and default a viewed user with no role to the least-privileged User role. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Display text is separate from the dropdown selection: the read-only input shows 'No role found' and the admin dropdown stays on 'Select a role...' instead of implying a User role the account does not have. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the dependency, Windows Electron restoration, and administration role-handling changes.
No open issues 🎉
What changed in this PR
This PR addresses dependency security warnings, improves Windows Electron restoration, and fixes role handling in the administration user-details page.
Changes:
- Adds explicit references to AngleSharp and System.Security.Cryptography.Pkcs.
- Replaces PowerShell-based Electron cache lookup and extraction with MSBuild tasks on Windows.
- Fixes role-variable shadowing and adds handling for missing organization context.
| File | Description |
|---|---|
6-Tests/Nine.Shared.UI.Tests/Nine.Shared.UI.Tests.csproj |
Adds AngleSharp 1.5.0 to the UI test project. |
4-Nine/Nine.csproj |
Adds the cryptography dependency and replaces Windows Electron restoration commands. |
4-Nine/Features/Administration/Users/View.razor |
Corrects role handling and displays organization-context errors. |
Review effort: Balanced
xnodeoncode
approved these changes
Nov 12, 2026
xnodeoncode
left a comment
xnodeoncode
left a comment
Owner
There was a problem hiding this comment.
All changes have been reviewed and confirmed to not adversely affect existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Electron build issue on Windows by switching from Powershell to MSBuild commands in the Nine.csproj file. Updated package references for Cyptography and AngleSharp in Nine.csproj and Nine.Shared.UI.Tests.csproj files. Fixed shadowing bug in Users/View.cshtml file.