Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_HOME, current model, provider endpoint, and model catalogue without falling back to the default profilemodel.defaultwhile preserving provider credentials, endpoint settings, and unrelated YAML sectionsThe picker is synthetic only while Hermes does not advertise its own ACP model option. If a future adapter provides one, the agent-owned option takes precedence.
Closes #776
Verification
vitest run src/hooks/use-hermes-model-option.test.tsx src/components/chat/hermes-model-option-wiring.test.ts— 13 passedeslinton all changed TypeScript/TSX filestsc --noEmit --pretty falsecargo test --features test-utils --lib commands::acp::tests— 246 passedcargo checkcargo check --no-default-features --bin codeg-servercargo clippy --all-targets --features test-utils -- -D warningscargo clippy --no-default-features --bin codeg-server --lib -- -D warnings