Repository navigation
Fix transcript losing its bottom pin to keyboard/layout changes - #16
Open
PanAndDuck wants to merge 1 commit into
Open
PanAndDuck wants to merge 1 commit into
PanAndDuck wants to merge 1 commit into
Conversation
Tapping the compose field (or sending a message while it's focused) could leave the newest message hidden behind the keyboard, and dismissing the keyboard wouldn't re-settle the scroll either. Root cause: the single geometry observer driving `stuckToBottom` treated ANY offset shift that crossed the bottom threshold as "the user scrolled away", including shifts caused by the keyboard shrinking the visible area or by rows still finishing their layout — so a keyboard show/hide routinely (and silently) unpinned the transcript from the bottom it was actually still following. `onScrollPhaseChange` now distinguishes a genuine user-driven scroll (`.tracking`/`.interacting`/`.decelerating`) from a passive layout change. Only a real user scroll may unpin the viewport; while pinned, a content/container/inset size change (keyboard, compose-bar height, late row measurement) instead re-asserts the bottom anchor. Verified on Simulator with a live server: screenshots confirm the newest message stays visible with the keyboard shown, the transcript still tracks the bottom once it's dismissed, and a freshly-sent message scrolls into view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stuckToBottomtreated ANY offset shift crossing the bottom threshold as "the user scrolled away" — including shifts caused by the keyboard shrinking the visible area, or by rows still finishing their layout. A keyboard show/hide could therefore silently unpin the transcript from the bottom it was actually still supposed to be following.onScrollPhaseChangenow distinguishes a genuine user-driven scroll (.tracking/.interacting/.decelerating) from a passive layout change. Only a real user scroll can unpin the viewport; while pinned, a content/container/inset size change (keyboard, compose-bar height, late row measurement) instead re-asserts the bottom anchor.Test plan