Repository navigation
Fix Expert Skills calling a non-existent web-mode endpoint - #15
Open
PanAndDuck wants to merge 1 commit into
Open
PanAndDuck wants to merge 1 commit into
PanAndDuck wants to merge 1 commit into
Conversation
The "+" menu's Expert Skills list posted to `experts_list_for_agent`, which does not exist anywhere server-side (not as a Tauri command, not as a web route) — every request 501'd with "API endpoint 'experts_list_for_agent' is not available in web mode" whenever the app talked to codeg-server / the desktop app's Web Service (i.e. any non-LAN setup), leaving Expert Skills permanently broken there. There is no server-side "experts for one agent" endpoint at all — the web client derives this client-side too (see its `use-enabled-skill-ids.ts`): fetch the global expert catalog (`experts_list`) plus the bulk per-(expert, agent) link-status snapshot (`experts_list_all_install_statuses`), then keep only the entries linked to the agent in question. `CodegClient.experts(agentType:)` now does the same, and a new `expertsAllInstallStatuses()` wraps the bulk endpoint. Verified: builds and runs on Simulator and a physical device against a codeg-server (Web Service) instance; Expert Skills now lists the expected linked experts instead of erroring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experts_list_for_agent, an endpoint that does not exist anywhere server-side (not a Tauri command, not a web route). Every request 501'd withAPI endpoint 'experts_list_for_agent' is not available in web mode, so Expert Skills was permanently broken whenever the app talked tocodeg-server/ the desktop app's Web Service — i.e. any non-LAN setup.use-enabled-skill-ids.ts): fetch the global expert catalog (experts_list) plus the bulk per-(expert, agent)link-status snapshot (experts_list_all_install_statuses), then keep only entries linked to the agent in question.CodegClient.experts(agentType:)now does the same; a newexpertsAllInstallStatuses()wraps the bulk endpoint (already modeled by the existingExpertInstallStatustype used elsewhere in Settings).Test plan
codeg-server(Web Service) instance