Repository navigation
Conversation
* reduced number of requests for Statement * move meta orchestration * detect prepared statement
This reverts commit b57550f.
Restore source-compatible exception declarations and map prepared-statement transition failures to SQLException.
Dispatch Avatica operations through package-private hooks and guard the public statement API surface.
Keep FlightEndpointDataQueue fail-fast while normalizing cancellation races inside the JDBC result-set path.
Remove redundant API visibility and interface identity tests, retain the checked prepareStatement implementation, and clarify connection ownership comments.
testShouldInterruptFlightStreamsIfQueryIsCancelledMidQuerying called statement.cancel() right after starting the worker thread. It relied on the prepare round trip in executeQuery to make the cancel land before a result set existed, so only Avatica's cancel flag was set and next() threw "Statement canceled". Statement.executeQuery no longer prepares first, so the cancel can now land while the result set is executing and surface as "Error while executing SQL ...: exception while executing query: Statement canceled", which failed the RC Binaries job. Wait until executeQuery returns before cancelling, and replace the 300 ms sleep with a latch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-only mirror of apache#1090. Do not merge.
optimize-queries-3at4d1556fd1ef414e81503278e4682bb612fe2e3dd.codex/pr-1090-ci-baseata9f144203f94784b5094170350507d4182602e01, pinned to the current upstream PR base.Purpose: run the existing Test, Integration, RC and Dev workflows against the same proposed merge as upstream PR 1090.
No source or workflow changes were added. The fork main branch and upstream PR remain unchanged.