Repository navigation
Fix generator virtual-time test race - #82
Merged
Merged
Conversation
Test Results471 tests +4 469 ✅ +4 32s ⏱️ +4s Results for commit 839e0bf. ± Comparison against base commit 40524c7. This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 33 33
Lines 1002 1002
Branches 173 173
=======================================
Hits 929 929
Misses 50 50
Partials 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Track live timers in the test time provider, skipping ones disposed before they are observed, and advance until a goal completes instead of assuming how many timers the runner creates. Check the deadline on every iteration so callbacks that register timers synchronously cannot hang the test, and give the regression test an independent fail-safe. Also synchronize the readiness-deadline and cancellation-precedence tests with the runner, settle before negative assertions, and centralize the real-time test timeout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the generator test-harness race that blocked the publishing run after #81. Compilation succeeded;
Container_startup_has_a_bounded_readiness_deadlinefailed because the shared clock helper exhausted 6,000 virtual-time spins before queued asynchronous continuations ran. The same helper caused the earlier intermittent continuous-recovery failure.FakeTimeProvider. Tests advance only after the scenario registers its next timer.Task.Yield.Only generator tests change. Runtime behavior, library contracts, dependencies, and the AgentDocs upgrade are unchanged.
Verification
DOTNET_PROCESSOR_COUNT=1: 6,500 successful test executions.dotnet format --verify-no-changes --no-restore.The publishing workflow has not been rerun and no packages have been published as part of this fix.