Skip to content

ci: reduce benchmark job runtime - #120

Merged
robjtede merged 2 commits into
mainfrom
t3/add-memory-profiling-ci
Nov 7, 2026
Merged

robjtede merged 2 commits into
mainfrom
t3/add-memory-profiling-ci

Conversation

@robjtede

@robjtede robjtede commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Reduce benchmark job runtime while retaining walltime and memory measurements. Request ten timing samples with 10,000 iterations each, with a 500 ms cap per benchmark. Cache the CodSpeed walltime and analysis build directories, including workspace crates, and use faster cache compression. Remove ready_for_review and workflow_dispatch triggers.

Validation: workflow formatting passes. CI experiments are ongoing; the target is a complete benchmark job below two minutes with useful measurements. The first experiment exceeded that target and collected too few timing samples, so these settings remain under evaluation.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9839217f-2883-4dee-a72b-9abfe90c79f3
Commits

Reviewing files that changed from the base of the PR and between f7ee6d0 and 419a32c.

Files selected for processing: 1

  • .github/workflows/benchmark.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.29%

❌ 1 regressed benchmark
✅ 225 untouched benchmarks
⏩ 77 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime parse_http_3 6 ns 7 ns -14.29%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing t3/add-memory-profiling-ci (419a32c) with main (f7ee6d0)

Open in CodSpeed

Footnotes

  1. 77 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robjtede
robjtede merged commit 9320c8e into main Nov 7, 2026
10 of 11 checks passed
@robjtede
robjtede deleted the t3/add-memory-profiling-ci branch November 7, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant