Repository navigation
Conversation
puzlwerk-viewer-0.1.0-dedf9d00.tgz (wstein/puzlwerk dedf9d00) as a file dependency, pinned in vendor/viewer.json with its SHA-256 and checked by npm run verify:viewer-vendor (part of typecheck). vendor/README.md records provenance and licenses; no registry, no gitlink. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Both recovery dialogs render their 3D preview through CubeView3DChoice. With ?viewer=puzlwerk it is the shared viewer (sizes 2-7, view only, face outline through setStickerHighlight, CubeState translated in @puzlwerk/viewer/bridge); otherwise the existing view, unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ntries puzlwerk-viewer-0.1.0-0ecbe3e8.tgz (wstein/puzlwerk 0ecbe3e8) replaces the dedf9d00 build; the CubeState translation is imported from @puzlwerk/viewer/bridge/cube-state. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replaces the 0ecbe3e8 archive (SHA-256 in vendor/viewer.json and vendor/README.md); the viewer package now covers the review findings of wstein/puzlwerk#91. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: FINDINGS head=dc429f9978c07a25789b8420b3711e5f2b9ade3d patch-id=6b433d576045f2e6c5dd4757b34bccba05f3ddb7 pr=64 |
…ht signal from IDs The isometric start orientation is a quaternion computed in puzlwerkOrientation.ts (unit-tested), so the app declares no dependency on three. data-highlight now reports the face of the IDs actually passed to the viewer instead of the requested face. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and the WebGL message Inspecting Up, Down and Left must give exactly that face with n*n stickers for sizes 4, 5 and 7; the "Find a matching cube" dialog is covered with the flag; closing the dialog must lose the WebGL context; without WebGL the alert "3D view unavailable" must show. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: CLEAR head=830fba180feb6eb1de87e70c181400d0d458e0c0 patch-id=396d2b84fc4b750827b73063da030785bb45adef pr=64 |
Core is dual licensed EUPL-1.2 OR AGPL-3.0-or-later (owner decision 2026-11-17); this project uses the AGPL choice. The 0.3.0 capture-recovery archive is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: CLEAR head=8f46659d949ff6fe2ecb5c55b137d9cd30f7d325 patch-id=75503072ad68dd7fc3dc2e4232b6e9225945a4e2 pr=64 |
verify:viewer-vendor fails when README.md names another archive, SHA-256 or source revision. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: CLEAR head=ff6642c4e86818021766d140997e9cf7af810375 patch-id=478b4de38efc99c228810b162f5a97efba99099e pr=64 |
Spike, not a migration: the capture-review 3D preview on the shared
@puzlwerk/viewer(#29, owner decisions 2026-11-17). Native look of the new viewer, no pixel parity. Depends on wstein/puzlwerk#91 (translation, highlight, tarball).How to compare (owner):
npm install && npm run dev, openhttp://localhost:5173/(old view) andhttp://localhost:5173/?viewer=puzlwerk(new view). Card "Upload files":test/fixtures/synthetic-4x4-high.zip,orientation-recovery-5x5.zip,orientation-recovery-7x7.zip; then "Alternatives (n)", orphoto-identity-4x4-2026-11-16T21-28-43.zipand "Find a matching cube". The preview outlines the inspected face. No zip fixture exists for 2x2 and 3x3.Changes:
vendor/puzlwerk-viewer-0.1.0-7e14cbd8.tgz(SHA-256 invendor/README.md, pinned invendor/viewer.json,npm run verify:viewer-vendorin typecheck). Commit 0dad368 added the superseded dedf9d00 archive (157 kB); it and the aa725fda archive stay in history (no rewrite). Archive 7e14cbd8 carries the dual Core license (owner decision 2026-11-17:EUPL-1.2 OR AGPL-3.0-or-later, this project uses the AGPL choice); the vendored capture-recovery 0.3.0 archive is unchanged.PuzlwerkCubeView,CubeView3DChoice: both recovery dialogs choose by?viewer=puzlwerk; the old view stays the default. No adapter layer; no directthreedependency.Differences: view only (no turns, undo, scramble, gizmo, hint); darker lighting, contact shadow, fov 18; outline per sticker of the face, no neighbor band; standard layer widths.
Bundle (gzip -9): old lazy 3D chunk 18.1 kB before, 17.5 kB after; new lazy chunk
puzlwerkCubeView198.0 kB (loaded only with the flag); entryindex131.2 kB + Stdlib_Option 0.66 kB + Primitive_int 0.18 kB = 132.0 kB vs 131.7 kB (index+jsxRuntime) before (+0.3 kB).Tests (Node 22.23.4):
typecheck,lint,format:check,buildpass; vitest 1391 pass, 47 fail as on main (Git LFS photos), 1386 pass on main; Playwrightviewer-spike7 pass (4/5/7 inspect Up/Down/Left, search dialog, context release, no-WebGL alert, no flag). Mutations (always-Up highlight, dialog reverted, no dispose, no alert, orientation) fail.Not verified: skipping the
setStickerHighlightcall itself (no pixel assertion); real GPU, touch; Pages build.Open owner questions:
public/licenses/index.htmlnames neither three.js (MIT, now bundled), the viewer nor the Core (separate PR #65);@types/threeis a runtime dependency of the viewer package (see wstein/puzlwerk#91).Blocker: owner acceptance of the spike (live comparison old vs new viewer) and merge of wstein/puzlwerk#91 (the vendored viewer package is built from it).
Refs #29
🤖 Generated with Claude Code