Skip to content

docs(view3d): add viewer migration inventory - #62

Merged
wstein merged 2 commits into
mainfrom
docs/viewer-migration-inventory
Nov 17, 2026
Merged

wstein merged 2 commits into
mainfrom
docs/viewer-migration-inventory

Conversation

@wstein

@wstein wstein commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Purpose: fact base for the approved viewer-migration spike (#29, owner comment 2026-11-17). Documentation only, no product code.

Changes:

  • docs/viewer-migration-inventory.md: function table of src/client/view3d/ against @puzlwerk/viewer and core-viewer-bridge, callers, gaps (feat(viewer): restore CubeAssembler source-mesh rendering in the native scene puzlwerk#87 and 10 more), measurements, acceptance cases, license facts, open questions, proposed spike order.
  • Review round 1: translation layer recorded as decided in PuzlWerk, swipe tuning, vibration and Preferences.res dependencies added, capture spec list corrected, Biome formatting.

Head: 1ff8623. Review: CLEAR at this head (round 2, comment on this PR). CI run 44147641739 (typos, test) success.

Checks run:

  • typos on the file, git diff --check, biome format . (Biome 2.6.6): clean.
  • 10 new citations re-read against the files.
  • Pages bundle sizes with curl and gzip -9; three@0.187.0 from jsDelivr.

Not verified:

  • npm run build of this revision (no linux-arm64 ReScript binary): bundle size UNKNOWN.
  • rescript format --check: not run. Viewer tree-shaken size, gesture threshold parity, movePolicy any with inner slices: UNKNOWN (listed in the document).

Blocker: None.

🤖 Generated with Claude Code

Inventory of src/client/view3d against @puzlwerk/viewer and
core-viewer-bridge: function table, callers, gaps, measurements,
acceptance cases, license facts and a proposed spike order.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=e75b9d8ffdb59795073ff9af3d10671be2153440 patch-id=16e43bc24e942adb2b2d1ae62f34951213b27134 pr=62
blocking: docs/viewer-migration-inventory.md:34,106,108,115,178-179,195-196 keep the home of the translation layer open ("app or PuzlWerk", "or A", "needs owner confirmation", open question 3). Owner decision item 3 (#29, comment 2026-11-17) already places missing translation in the shared package; state P as decided, drop A for translation.
blocking: CI run 44146365662 (pull_request) fails at npm run format:check: Biome reformats the Markdown tables (lines 52-150). Run npm run format.
blocking: lines 79,89: e2e/explicit-capture-recovery.spec.ts:533 asserts .spatial-workspace canvas is visible, and the only canvas there is the 3D one. Three capture specs check the canvas, not two; "no 3D selector" is wrong.
blocking: missing functions and callers: swipe tuning settings (startPx, commitFraction, flickMs; settingsPage.tsx:254-276), wide-turn vibration (useCubeGestures.ts:142, settingsPage.tsx:220-233), and src/core/app/Preferences.res:156-177, which uses TurnFeel and CubeGesture. Lines 84-92 omit them. Step 6 (line 207) would break them.
nit: bare #87 at lines 54,58,144,176; write wstein/puzlwerk#87.
nit: line 92: useScannerAppModel.ts:65 and cubeDisplayCard.tsx:18 also use AxisGizmo.gen (ColorFrame).
nit: lines 23-25: "takes only" leaves out the moves, frame and callback props (cubeView3D.tsx:24-41).
nit: G3 could cite the hard-coded 2x2 R/U face-to-axis table in puzlwerk acceptance/runtime/cube-assembler.mjs:71.
nit: PR body: "owner merge" is not a Ready blocker.
Verified: more than 60 citations in both repos match, including (a) createPlayer and no CubeState translator, (b) stage-host.ts:23,68, (c) the missing features, (d) native-projection.ts:10, (e) and the license facts (f).
Bundle numbers reproduced exactly (Pages curl plus gzip -9, jsDelivr, npm registry unpackedSize). typos and git diff --check are clean; author and committer match the config identity; Co-Authored-By is present; no session links.

Record the owner decision that the translation lives in PuzlWerk, add the
swipe tuning, vibration and Preferences dependencies, correct the capture
spec list, qualify issue references and format the tables with Biome.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=1ff8623c63c945324685f5c6fd4529f12af4517e patch-id=987e4640067254bf4dd386a313b8c3ecc370f385 pr=62
Delta review against e75b9d8. All four blocking findings and the five nits from round 1 are resolved at the primary sources.
B1: lines 36-40, G1, G3, G10, open question 3 and spike step 1 place the translation in PuzlWerk beside core-viewer-bridge. No open location question or app option remains for translation. This matches owner decision item 3.
B2: CI run 44147641739 (pull_request, attempt 1) succeeded. git diff -w --word-diff against e75b9d8 shows only the listed content changes plus table padding, so the round-1 citations still hold.
B3: explicit-capture-recovery.spec.ts:533 and cubeView3DPresentation.tsx:114 are cited correctly; the capture row now lists three specs.
B4: the vibration and swipe-tuning rows check out: useCubeGestures.ts:142,185,219,312, cubeGesture.ts:60-89, settingsPage.tsx:220-233,254-276, Preferences.res:156-177, settings.spec.ts:192, puzlwerk play-gesture.ts GestureOptions. Step 6 names the dependencies.
Nits fixed: wstein/puzlwerk#87, useScannerAppModel.ts:64-65, cubeDisplayCard.tsx:15-18, the full prop list, acceptance/runtime/cube-assembler.mjs:71, and the PR blocker line.
nit: the settingsPage.tsx caller row lists only vibration and swipe tuning. Seam wide (:245), scramble length and inner layers (:286-301) and turn time and overshoot (:207-214) also feed view3d.
nit: test/properties/GestureProperties_test.res uses CubeGesture and is not named.
nit: line 116 has a bare #29.
typos and git diff --check are clean; author and committer match the config identity; Co-Authored-By is present. The PR body has 20 lines, a Blocker line and the Generated line; no session links.

@wstein
wstein marked this pull request as ready for review November 17, 2026 18:35
@wstein
wstein merged commit 61d8b43 into main Nov 17, 2026
2 checks passed
@wstein
wstein deleted the docs/viewer-migration-inventory branch November 17, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant