Skip to content

Use cached plugin and theme installs in tests - #403

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time -7.5% (165.9 → 153.4 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Tests
    • Updated block scaffolding, linting, and theme test scenarios to use themes configured as installed and active before the commands run. Theme setup is now consistent across the affected scenarios.
    • No end-user-facing feature or behavior changes are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c4ed8ed8-ad4e-4809-b381-8bf29f4b3104
Commits

Reviewing files that changed from the base of the PR and between ddceb92 and 4e55a47.

Files selected for processing: 4
  • composer.json
  • features/scaffold-block.feature
  • features/scaffold-lint.feature
  • features/scaffold-theme-tests.feature

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The development dependency constraint for wp-cli/wp-cli-tests changes to ^5.4.0. Scaffold feature scenarios replace theme installation commands with installed-theme fixture declarations.

Changes: Scaffold test setup

Layer / File(s) Summary
Test dependency constraint
composer.json
The wp-cli/wp-cli-tests development dependency constraint changes from ^5 to ^5.4.0.
Theme fixture setup
features/scaffold-block.feature, features/scaffold-lint.feature, features/scaffold-theme-tests.feature
Scaffold scenarios declare Twenty Twelve or Twenty Twenty-One as installed and, where specified, active themes through fixtures instead of running theme installation commands.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: swissspidy, ernilambar

Merge Risk: Minimal · up to 4e55a

No merge-blocking issue is identified in the cached theme-fixture migration. Merge after normal dependency and test checks pass.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: replacing direct plugin and theme installations with cached installs in tests.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added automated-pr scope:testing Related to testing labels Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from 62cad35 to 4e55a47 Compare November 2, 2026 02:57
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:57
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:57
@schlessera
schlessera merged commit 054de43 into main Nov 2, 2026
52 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:03
@schlessera schlessera added this to the 3.0.3 milestone Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant