Repository navigation
Use {PLUGIN_DIR} and {THEME_DIR} in tests - #402
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove path lookup steps features/install-wp-tests.feature, features/scaffold-lint.feature, features/scaffold-plugin-tests.feature, features/scaffold-theme-tests.feature, features/scaffold.feature |
Removed wp plugin path and wp theme path commands and the steps that saved their output as {PLUGIN_DIR} or {THEME_DIR}. Scaffold commands and subsequent checks remain. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested labels: command:scaffold-_s
Suggested reviewers: swissspidy, ernilambar
Merge Risk: 
Minimal · up to 05303
-
The scenario changes introduce no identified merge-blocking risk and appear ready to merge after normal checks.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c65cc57 to
05303d5
Compare
{PLUGIN_DIR} and {THEME_DIR} in tests
Switches the feature files to the built-in
{PLUGIN_DIR}and{THEME_DIR}variables from wp-cli/wp-cli-tests#397, and requireswp-cli/wp-cli-tests^5.4.0.Measured on this test suite: Behat time -9.4% (178.5 → 161.8 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#397.
Summary by CodeRabbit