Fix: update blog count in pill on site block - #23290
Open
coderGtm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21146. In Reader → Subscriptions, blocking a site via the post overflow menu ("Block this site") hid the post but left the "N Blog" filter pill showing a stale count until pull-to-refresh.
The pill count (
blogsFilterCountinReaderViewModel.TopBarUiState) is recomputed only whenSubFilterViewModel.subFiltersre-emits, which happens solely when theReaderEvents.FollowedBlogsFetchedevent is posted — previously only byReaderUpdateLogicduring a full tags/blogs sync (the pull-to-refresh path). The block flow refreshed the posts adapter and mutated the DB but never emitted this event.This PR makes
handleBlockSiteClickedemitFollowedBlogsFetched(with the fresh count fromReaderBlogTableWrapper.getFollowedBlogs()) after every DB mutation: on local block, on snackbar undo, and onRequestFailed(whose failure path re-follows the blog). The pill now updates immediately to "0 Blogs".Testing instructions
Blocking a site in the Subscriptions tab:
Undoing a blocked site:
Blocking a site fails (no network / request failure):
Regression check — other Reader entry points:
Screen recording
Screen_recording_20260903_174715.webm