fix(ios): return NO from PdfManager requiresMainQueueSetup (#1021) - #1027
Open
hmadhsan wants to merge 1 commit into
Open
fix(ios): return NO from PdfManager requiresMainQueueSetup (#1021)#1027hmadhsan wants to merge 1 commit into
hmadhsan wants to merge 1 commit into
Conversation
Signed-off-by: hmadhsan <20043390+hmadhsan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1021
🐛 What was the issue?
PdfManagerinios/RNPDFPdf/PdfManager.mmreturnedYESfrom+requiresMainQueueSetup, despite having an emptyinitmethod that performs no UIKit or main-thread initialization work.Returning
YESunnecessarily forces React Native bridge setup forPdfManageronto the main thread viadispatch_sync, which can cause performance bottlenecks and rare app hang issues on iOS during app startup.🛠️ What did we fix?
+requiresMainQueueSetupinios/RNPDFPdf/PdfManager.mmto returnNO.RNPDFPdfViewManager.mm,RNPDFPdfPageViewManager.mm) unchanged as view managers construct UI components on the main thread.🧪 Testing & Verification
PdfManagerdoes not execute any UIKit or UI calls ininitor module setup.NOallows React Native to initializePdfManageroff the main queue safely without blocking bridge setup.