Append DOM editable fallback refs to accessibility snapshots - #53
Merged
Merged
Conversation
Full-tree accessibility snapshots now mint dom_fallback textbox nodes for textarea, text-like input, and contenteditable elements that never entered Chrome's debugger-backed accessibility tree, such as framework pre-hydration composers. The revisioned refs work with the existing fill, type, and click paths, elements already covered by the accessibility tree are skipped, and fallback capture failures never fail the snapshot.
![omp-maintainer[bot]](https://avatars.githubusercontent.com/in/4804189?s=60&v=4){kind=small}
There was a problem hiding this comment.
P1 — scoped root-cause fix with focused coverage, but two snapshot-boundary defects need correction before merge.
Blocking: the fallback cap is applied before eligibility filtering, and max_nodes/truncated do not account for appended or omitted fallback nodes.
Should-fix: use the repository's #private member convention.
Thanks for the targeted fix.
…dget - Keep scanning DOM matches until 40 editables are accepted, with a separate 400-inspection work bound, so pages whose early matches are all accessibility-covered or unsupported still reach a missing pre-hydration composer. - Apply max_nodes to the combined fallback + accessibility result with fallback editables leading the list, and report truncated whenever either side is omitted. - Rename the helper to #domEditableFallbackNodes per repository convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some frameworks render editable elements that never enter Chrome's debugger-backed accessibility tree — for example pre-hydration composer textareas.
browser_snapshotin accessibility mode mints refs only fromAccessibility.getFullAXTree, so those elements have no addressable ref andfill/typecannot reach them.Change
Full-tree accessibility snapshots now append up to 40
dom_fallbacktextbox nodes minted from a DOMquerySelectorAll("textarea,input,[contenteditable]")pass:ref(r<revision>-<backendNodeId>) that the existing fill/type/click paths already accept — no schema or adapter change anywhere.root_ref) snapshots are unchanged.stale_revision.Verification
packages/extensionsuite: 116 pass (2 new tests: fallback node minting incl. AX-duplicate and non-editable filtering; end-to-end fill through a fallback ref).tsc --noEmitclean; dev extension bundle builds with the same keyed extension ID.