random: add wc_InitRngFixedSeed() for FIPS known-answer tests - #11452
Open
kaleb-himes wants to merge 1 commit into
Open
random: add wc_InitRngFixedSeed() for FIPS known-answer tests#11452kaleb-himes wants to merge 1 commit into
kaleb-himes wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11452
Scan targets checked: none
Failed targets: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Contributor
Author
|
@wolfSSL-Fenrir-bot review force |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CAST tests in the FIPS module have historically used real entropy in their tests. To be a true "Known Answer Test" they need to use a fixed seed instead of a random one. This PR adds a non-public API (internal only) and since the module owns every call site to _InitRng we control which API's pass an explicit NULL, 0 for the new input parameters and only one API (non-public by design) actually passes a fixed seed ever.
Testing
With modified versions of the CASTs in fips_test.c to pass a static seed vs a random seed.
Checklist