Skip to content

bsdkm: wc_static_assert define. - #11451

Open
philljj wants to merge 1 commit into
wolfSSL:masterfrom
philljj:bsdkm_fixes
Open

bsdkm: wc_static_assert define.#11451
philljj wants to merge 1 commit into
wolfSSL:masterfrom
philljj:bsdkm_fixes

Conversation

@philljj

@philljj philljj commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Description

Add missing assert define for bsdkm build.

Fixes fips-bsdkm build.

Testing

  FIPS_CFLAGS="-DWOLFSSL_BSDKM_VERBOSE_DEBUG -DWOLFCRYPT_FIPS_CORE_HASH_VALUE=$fips_hash"
  ./configure --enable-freebsdkm --enable-cryptonly \
    --enable-crypttests \
    --enable-fips=v7 \
    CFLAGS="$BASE_CFLAGS $FIPS_CFLAGS" \
    || exit 1

make && sudo kldload bsdkm/libwolfssl.ko || exit 1

dmesg output from kldload and unload:

info: wolfkmod_event: MOD_LOAD
info: FIPS 140-3 wolfCrypt-fips v7.0.0 startup self-test succeeded.
------------------------------------------------------------------------------
 wolfSSL version 5.9.2
------------------------------------------------------------------------------
wc_RunAllCast_fips passed.
macro    test passed!
error    test passed!
MEMORY   test passed!
...
SLH-DSA  test passed!
CMAC     test passed!
mp       test passed!
logging  test passed!
mutex    test passed!
Test complete
info: wolfCrypt self-test passed.
info: libwolfssl loaded
info: wolfkmod_event: MOD_QUIESCE
info: wolfkmod_event: MOD_UNLOAD
info: wolfCrypt FIPS re-self-test succeeded at unload: all algorithms re-verified.
info: libwolfssl 5.9.2 cleanup complete.
info: libwolfssl unloaded

@philljj philljj self-assigned this Sep 12, 2026
Copilot AI lite review requested due to automatic review settings September 12, 2026 22:09
@philljj philljj added the For This Release Release version 5.9.4 label Sep 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed change has no unresolved issues.

Pull request overview

Adds missing FreeBSD kernel-module static assertion macros to fix FIPS BSDKM builds.

Changes:

  • Defines wc_static_assert and wc_static_assert2 using C11 _Static_assert.
File summaries
File Summary
wolfssl/wolfcrypt/types.h Adds FreeBSD kernel-module static assertion definitions.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@philljj philljj assigned wolfSSL-Bot and unassigned philljj Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants