Fix KeyGen tests expected returns when caller supplied seed - #11450
Open
kaleb-himes wants to merge 9 commits into
Open
Fix KeyGen tests expected returns when caller supplied seed#11450kaleb-himes wants to merge 9 commits into
kaleb-himes wants to merge 9 commits into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11450
Scan targets checked: none
Failed targets: wolfssl-bugs
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11450
Scan targets checked: none
Failed targets: wolfssl-bugs
Contributor
Author
|
@wolfSSL-Fenrir-bot review force |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11450
Scan targets checked: none
Failed targets: wolfssl-bugs
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A caller supplied seed is not-approved when the module does not control the seed material, adjust tests to expect the WC_FIPS_NOT_APPROVED return (services are rendered but explicit indicator of not-approved returned)
Checklist