XTS Streaming .S and _c.c implementations, streaming callers & SVR brackets for aarch64 - #11423
kaleb-himes wants to merge 19 commits into
Conversation
|
e276d22 to
970b6bf
Compare
|
retest this please. |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
d17f573 to
44de270
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
e492336 to
a27db55
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): linuxkm-src, linuxkm-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
a27db55 to
3672e6b
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: linuxkm-src, linuxkm-bugs
Unchanged since last review (not re-run): wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
|
@wolfSSL-Fenrir-bot review force |
Dismiss to re-request
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11423
Scan targets checked: none
Failed targets: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
|
Fenrir just keeps err'ing out so I checked the Fenrir PR review page, it says 0 new findings and the other 14 have either been fixed or determined to be pre-existing items that are out of scope of what this PR is doing. |
| #ifndef RESTORE_VECTOR_REGISTERS | ||
| #define RESTORE_VECTOR_REGISTERS() restore_vector_registers_arm() | ||
| #endif | ||
| #error kernel module 32-bit ARM SIMD is not yet tested or usable. |
There was a problem hiding this comment.
NOTE: This is being addressed/fixed in branch N (#11413) but branch N is on top of this PR (branch L) so L has to merge before N can be considered for merge to plug the 32-bit gaps.
Description
https://github.com/wolfSSL/scripts/pull/670
taught the aarch64 crypto-extension generator to emit the AES-XTS streaming routines, but that PR regenerated only the MASM (armv8-aes-asm.asm). This PR regenerates the .S and _c.c twins from that same, already-merged generator so all three outputs agree. armv8-aes-asm.asm is untouched here and there is no partner scripts/ PR because 670 already did all the work.
In addition to the regenerated files:
aes.c / aes.h: The streaming callers dispatch into the crypto-extension asm (47 + 8 lines)
SAVE/RESTORE_VECTOR_REGISTERS claims around the aarch64 NEON and crypto lanes: aes.c, sha256.c, sha512.c, wc_mlkem.c, wc_mlkem_poly.c
SHA-3 aarch64 crypto lane claims the vector registers (sha3.c)
linuxkm arm64 vector-register glue on kernel_neon_begin, enabling ARM SIMD in the kernel module (linuxkm/arm64_vector_register_glue.c, plus Kbuild/PIE-table/configure plumbing)
NOTE: There is a known NEON gap for any aarch64 device that does NOT have the crypto extensions and I am happy to add that as a followup PR but this PR was already just over 5k lines of additions and adding that would have swelled it to 16-17k lines + a scripts/ generator update to go with it and that felt like too much to take on in a single PR.
Fixes zd#
Testing
Checklist