TLS Extensions: add more extensions and improve current - #11362
Conversation
81d6404 to
e16541a
Compare
|
646253f to
55ec736
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
55ec736 to
72e8586
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
72e8586 to
f512027
Compare
f512027 to
de17187
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
de17187 to
1882e64
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
1882e64 to
3557bfd
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
3557bfd to
f7c1db3
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 2
1 finding(s) posted as inline comments (see file-level comments below)
Required changes (1)
Certificate-entry extension index not advanced in SCT-only builds
File: src/tls13.c:11240
Function: SendTls13Certificate
Category: Logic errors
WriteCertEntryExts() is now reached under HAVE_CERTIFICATE_STATUS_REQUEST || HAVE_SIGNED_CERT_TIMESTAMP and inflates extSz[0] with the SCT list, but the chain loop's extIdx++ is still guarded on HAVE_CERTIFICATE_STATUS_REQUEST alone. With --enable-sct and no OCSP stapling, each chain entry reuses extSz[0] and certExts[0], already freed at line 11223, so AddCertExt() dereferences NULL at line 10096.
Recommendation: Widen the extIdx++ and FreeDer() guards at lines 11104, 11119 and 11240 to also include HAVE_SIGNED_CERT_TIMESTAMP, matching the call site at line 11017.
Referenced code: src/tls13.c:11240-11244 (5 lines)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
f7c1db3 to
0ee7e88
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11362
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
Added support for record_size_limit in TLS 1.3 and TLS 1.2. Added compress_certificate support for TLS 1.3. Added signed_certificate_timestamp TLS 1.2 and 1.3. Added handshake-message fragmentation to EncryptedExtension, CertificateRequest and NewSessionTicket. Accepts server_name in CertificateRequest. Added API for setting signature algorithms for signature_algorithms_cert. SHA-1 certificate chain fix: a peer advertising ecdsa_sha1 against a chain with an RSA-SHA1 intermediates will see a failed handshake. Tests added and interop performed where possible.
0ee7e88 to
a10491c
Compare
Description
Added support for record_size_limit in TLS 1.3 and TLS 1.2.
Added compress_certificate support for TLS 1.3.
Added signed_certificate_timestamp TLS 1.2 and 1.3.
Added handshake-message fragmentation to EncryptedExtension, CertificateRequest
and NewSessionTicket.
Accepts server_name in CertificateRequest.
Added API for setting signature algorithms for signature_algorithms_cert.
SHA-1 certificate chain fix: a peer advertising ecdsa_sha1 against a chain
with an RSA-SHA1 intermediates will see a failed handshake.
Tests added and interop performed where possible.
Testing
Regression tested TLS.