[dgarske]

The wolfBoot side of the NXP QorIQ SEC (CAAM) hardware crypto port added in wolfSSL/wolfssl#11199: SEC_QORIQ=1 compiles the wolfcrypt/src/port/nxp/sec_qoriq* objects into the T2080 and T1040 bare-metal test apps and selects the engine through the crypto callback layer. The apps register the device, run wolfcrypt_test() and benchmark() through it, and print the driver's offload counters, which matter because unhandled cases fall back to software and a passing test on its own proves nothing about offload. Also included: the lib/wolfssl repin to the commit carrying the port, a larger test-app stack for RSA-2048 under SP_MATH_ALL, the T1040's time base and SYSCLK, a RISC-V asm object-path fix, and TRACE32 no-reset attach scripts for both boards. Validated on a Curtiss-Wright VPX3-152 (T2080E) and an NXP T1040D4RDB (T1040E): wolfBoot verifies and boots the signed app and wolfcrypt_test() passes in full, with the counters confirming cipher and public-key work reaching the engine and hashing staying in software as the port intends.

[Copilot]

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds bare-metal test-app integration for NXP QorIQ SEC (CAAM) on PowerPC T2080/T1040 so wolfCrypt tests/benchmarks can run on real hardware while reporting SEC offload counters.

Changes:

• Add SEC_QORIQ build option and link the wolfSSL SEC QorIQ port into the test app.
• Enable SEC QorIQ init + offload counter reporting in the T2080 and T1040 test apps.
• Update PPC timing support (T1040 SYSCLK/timebase) and increase PPC stack size for large wolfCrypt test configurations.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test-app/wolfcrypt_support.c	Extends PPC timebase/timing support to TARGET_nxp_t1040 and corrects SYSCLK assumption.
test-app/app_nxp_t2080.c	Initializes SEC QorIQ in test/benchmark builds and prints offload counters; adds U-Boot/wolfBoot state handling.
test-app/app_nxp_t1040.c	Adds wolfCrypt test/benchmark harness and SEC QorIQ init + offload counter reporting.
test-app/PPC.ld	Increases bare-metal PPC stack allocation to accommodate deep wolfCrypt/RSA paths.
test-app/Makefile	Adds SEC_QORIQ build flag and PPC stack-usage limit override for wolfCrypt tests.
lib/wolfssl	Updates wolfSSL submodule pin (to include SEC QorIQ work).
.github/workflows/test-configs.yml	Adds CI build jobs to validate SEC QorIQ integration against the pinned wolfSSL revision.

Suppressed comments (1)

lib/wolfssl:1

• The PR description states that without SEC_QORIQ=1 the branch builds against the current wolfSSL pin unchanged, but this PR updates the lib/wolfssl submodule pin unconditionally. Recommendation (mandatory): either update the PR description to reflect the temporary pinning for CI, or avoid changing the pin in this PR (and instead fetch/override the wolfSSL revision only within the SEC_QORIQ CI jobs).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

It introduces a hardware-accelerator integration path that depends on external wolfSSL changes and is difficult to fully validate for correctness and build/link compatibility in this review context.

Review details

• Files reviewed: 9/9 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

Copilot review overview

🟡 Changes recommended

The advertised TRACE32 helper is absent, leaving the change set inconsistent with the PR description.

Review effort: Balanced
Findings: 2

Open (2)

• Add missing TRACE32 helper or remove it from PR description · New
• Correct header attribution for WC_USE_DEVID configuration · New

Resolved since last review (1)

• PR description says "Everything is confined to test-app/", but this PR also changes CI/workflow and…

[Copilot]

Copilot review overview

🟡 Changes recommended

CI does not compile the benchmark integration or the T1040 RSA/SP_MATH_ALL path.

Review effort: Balanced
Findings: 1

Open (1)

• T1040 CI omits benchmark and RSA compile coverage · New

Resolved since last review (2)

• Correct header attribution for WC_USE_DEVID configuration
• Add missing TRACE32 helper or remove it from PR description