Update hitch patch to fully fix test failures.

[kareem-wolfssl]

No description provided.

[Copilot]

Pull request overview

Updates the hitch_1.8.0.patch vendor patch to make Hitch’s upstream test suite pass reliably when built against wolfSSL, and to better document the remaining caveats around the wolfSSL/OpenSSL behavioral differences.

Changes:

• Refines build/configure logic to track NPN support and expose it to the test environment (HITCH_HAVE_NPN).
• Adjusts test scripts to avoid wolfSSL-specific TLS/cipher and client-cert flag mismatches (notably tests 13, 15, and 39).
• Expands patch header notes to document why these adjustments are needed and how to avoid stale-generated-parser failures in reused build trees.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[philljj]

What gcc version are you using?

I get build errors:

  CC       hitch-configuration.o
In file included from configuration.c:32:
foreign/vas.h:55:9: error: ‘assert’ redefined [-Werror]
   55 | #define assert(e)                                                       \
      |         ^~~~~~
In file included from /usr/local/include/wolfssl/wolfcrypt/types.h:2398,
                 from /usr/local/include/wolfssl/openssl/ssl.h:32,
                 from configuration.h:12,
                 from configuration.c:30:
/usr/include/assert.h:153:12: note: this is the location of the previous definition
  153 | #   define assert(...)                                                  \
      |            ^~~~~~
In file included from configuration.c:31:
configuration.c: In function ‘front_arg_new’:
foreign/miniobj.h:16:38: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
   16 |                 (to) = calloc(sizeof *(to), 1);                         \
      |                                      ^
configuration.c:152:9: note: in expansion of macro ‘ALLOC_OBJ’
  152 |         ALLOC_OBJ(fa, FRONT_ARG_MAGIC);

using

gcc --version
gcc (GCC) 16.2.1 20260819 (Red Hat 16.2.1-2)
Copyright (C) 2026 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.