patch for WC_PK_TYPE_EC_CHECK_PUB_KEY enum missing in wolfSSL 5.9.2 - #178
Open
JacobBarthelmeh wants to merge 1 commit into
Open
patch for WC_PK_TYPE_EC_CHECK_PUB_KEY enum missing in wolfSSL 5.9.2#178JacobBarthelmeh wants to merge 1 commit into
JacobBarthelmeh wants to merge 1 commit into
Conversation
JacobBarthelmeh
requested review from
wolfSSL-Fenrir-bot
and
a lite review from Copilot
September 3, 2026 20:21
There was a problem hiding this comment.
🟡 Changes recommended
The added patch appears incomplete for wh_client_crypto.c because it guards response helpers but leaves other references to the missing WC_PK_TYPE_EC_* request types unguarded, which can still break builds with wolfSSL 5.9.2.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the wolfHSM 1.5.0 Yocto recipe to apply a compatibility patch so wolfHSM can be staged/compiled against the layer’s wolfSSL 5.9.2, which lacks newer ECC crypto-callback request types used by wolfHSM 1.5.0.
Changes:
- Add a new recipe patch to the wolfHSM 1.5.0
SRC_URI. - Introduce a wolfHSM source patch that conditionally compiles out ECC make-public / check-public-key crypto-callback paths when building against wolfSSL 5.9.2 or older.
File summaries
| File | Description |
|---|---|
| recipes-wolfssl/wolfhsm/wolfhsm_1.5.0.bb | Adds the new compatibility patch to SRC_URI with rationale. |
| recipes-wolfssl/wolfhsm/files/0001-Guard-the-ECC-public-key-cryptocb-paths-on-the-wolfSSL-version.patch | Adds preprocessor guards around wolfHSM’s ECC public-key cryptocb-related code for older wolfSSL versions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.