insert date into cgo files to invalidate cache - #60
Open
sebastian-carpenter wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
README contains an invalid command placeholder and the generator uses a locale-dependent date string that can cause inconsistent generated output.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds an “options generation date” marker to cgo-bearing files and updates generateOptions.sh/README guidance so regenerating options can reliably invalidate Go’s build cache when the underlying wolfSSL install changes.
Changes:
- Add an
// Options generation date:marker to the per-package cgo directive carriers. - Update
generateOptions.shto write/update the date marker during option generation. - Update README instructions to reflect the expectation of rerunning
generateOptions.shwhen the wolfSSL install is modified.
File summaries
| File | Description |
|---|---|
| wolfx509/certgen_wolfcrypt.go | Adds options-generation date marker for wolfx509’s cgo directive carrier |
| wolftls/conn.go | Adds options-generation date marker for wolftls’ cgo directive carrier |
| aes.go | Adds options-generation date marker for wolfSSL package cgo directive carrier |
| examples/client/client-psk.go | Adds options-generation date marker to help invalidate cache for example build |
| examples/server/server-psk.go | Adds options-generation date marker to help invalidate cache for example build |
| generateOptions.sh | Writes the generation date into options.go and rewrites date markers across cgo files |
| README.md | Updates documentation to explain regeneration expectations and cache invalidation behavior |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Thoughts on this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying the underlying install of wolfssl may silently invalidate the binary go has cached for go-wolfssl.
For every package insert the date of options generation to help invalidate this cache. Updated README.md to reflect the new expectation of running
generateOptions.shwith each modification of the wolfssl install.