wolftls: require ServerName when peer verification is enabled - #51
Open
night1rider wants to merge 4 commits into
Open
wolftls: require ServerName when peer verification is enabled#51night1rider wants to merge 4 commits into
night1rider wants to merge 4 commits into
Conversation
lealem47
reviewed
Aug 12, 2026
| } | ||
|
|
||
| // A client with verification enabled must set ServerName; without it the | ||
| // certificate name is never checked, so reject rather than proceed. |
Contributor
There was a problem hiding this comment.
TIny nit: Document that this check is enforced to match crypto/tls
lealem47
requested changes
Aug 12, 2026
Update Config.ServerName/InsecureSkipVerify docs for the fail-closed requirement, assert the guard's error text, and add a test that InsecureSkipVerify allows an empty ServerName.
night1rider
force-pushed
the
fenrir-6394
branch
from
August 25, 2026 16:57
bf95afe to
ca95409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client with
InsecureSkipVerify=falsebut an emptyServerNamecurrently completes the handshake without ever checking the certificate's name.This rejects that configuration up front, matching
crypto/tls("eitherServerNameorInsecureSkipVerifymust be specified").Includes a
wolftlstest that fails before the change and passes after.